Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PLATFORM-1077) Adding CI/CD capabilities and Unit Tests #76

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

kbooker79
Copy link
Collaborator

@kbooker79 kbooker79 commented Feb 22, 2024

This PR enables running of the standalone Stochastic Physics unit tests, and automation of the standalone unit tests through the addition of a jenkins pipeline integration. The pipeline is spun-up via git labels and executed through a newly created jenkinsfile script.

@kbooker79 kbooker79 requested a review from pjpegion as a code owner February 22, 2024 17:38
@kbooker79 kbooker79 added the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Feb 22, 2024
@epic-cicd-jenkins epic-cicd-jenkins removed the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Feb 22, 2024
@kbooker79 kbooker79 added the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Feb 22, 2024
@epic-cicd-jenkins epic-cicd-jenkins removed the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Feb 22, 2024
@zach1221
Copy link
Collaborator

Hi, @kbooker79 . Can you please sync up the PR branch with master?

@zach1221 zach1221 added the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Aug 5, 2024
@epic-cicd-jenkins epic-cicd-jenkins removed the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Aug 5, 2024
@zach1221
Copy link
Collaborator

zach1221 commented Aug 5, 2024

@JeffBeck-NOAA I tested out the unit test pipeline, following our changes. Following the srun command (srun --label -A epic -n 24 standalone_stochy.x), the pipeline failed with the below.

At line 182 of file compns_stochy.F90 (unit = 21, file = 'input.nml')
1: Fortran runtime error: Cannot match namelist object name do_spp:

Does do_spp need to be enabled in compns_stochy.F90 as well, perhaps?

@JeffBeck-NOAA
Copy link
Contributor

Sorry, @zach1221. The following needs to be in the &gfs_physics_nml (not &nam_sppperts) section of input.nml:

do_spp = .true.
n_var_spp = 6 (if running with GF perturbations, 5 otherwise)

@zach1221 zach1221 added the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Aug 5, 2024
@epic-cicd-jenkins epic-cicd-jenkins removed the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Aug 5, 2024
@zach1221 zach1221 added the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Aug 6, 2024
@epic-cicd-jenkins epic-cicd-jenkins removed the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Aug 6, 2024
@zach1221 zach1221 added the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Feb 12, 2025
@epic-cicd-jenkins epic-cicd-jenkins removed the run-unit-tests Label to append in order to trigger CI/CD pipeline testing label Feb 12, 2025
@zach1221 zach1221 self-requested a review February 12, 2025 16:47
@zach1221
Copy link
Collaborator

@JeffBeck-NOAA @jkbk2004 fyi, the unit tests with spp enabled are working now, following input.nml changes from Jong. I have also successfully tested the stoch physics unit test pipeline, with the new jenkinsfile. Please feel free to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants