This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Add brushing on all charts #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Implement the mouse interactions and selection rendering for the histogram. No events are fired yet, so the brushing has no effect.
Fire a brush event from the ChartHistogram component. LoopDisplay listens for the event and updates a store with the brushed range. The range store is passed to the histograms, so that both loops will be synced.
I moved the map selection drawing to a separate canvas to speed up rendering. I have the region being set in the store and synced to the histograms and other map.
esheehan-gsl
force-pushed
the
87-brush-histograms
branch
from
142cc63 to
6a41625
Compare
Implement a selection mechanism for the 2D histogram. The chart-brush event is being dispatched, but the filter logic in LoopDisplay needs to be updated to support filtering on multiple dimensions.
Extract the `containedIn` filter definition to a reactive property that can build the range object for vector ranges based on the variable type. Separating this helps keep the mapData property a little more easy to read.
Since the range filter for vectors is incompatible with the range filter for scalars, we reset all the filters when you change variables.
esheehan-gsl
force-pushed
the
87-brush-histograms
branch
from
15a968b to
169d827
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for brushing the histogram and heatmap. Fix the brushing on the map.