Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ifi products to post #418

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Conversation

SamuelTrahanNOAA
Copy link

@SamuelTrahanNOAA SamuelTrahanNOAA commented Aug 19, 2022

DESCRIPTION OF CHANGES:

Adds IFI forecast products to the post output.

TESTS CONDUCTED:

Standalone tests of UPP only; workflow tests will happen soon.

DEPENDENCIES:

NOAA-GSL/UPP#36

DOCUMENTATION:

See this PR:
NOAA-EMC/UPP#536

@hu5970
Copy link

hu5970 commented Sep 16, 2022

@SamuelTrahanNOAA @EricJames-NOAA UPP code is ready. What the status of this PR? Thanks, Ming

@EricJames-NOAA
Copy link

@hu5970 @SamuelTrahanNOAA this update was tested as part of my Jet RRFS_CONUS_3km and RRFS_NA_3km tests. Sam, I think we can convert this from a draft PR to a real PR and get it reviewed and merged.

@hu5970
Copy link

hu5970 commented Sep 22, 2022

@SamuelTrahanNOAA @EricJames-NOAA Do we still need this PR to get ifi into RRFS system?

@SamuelTrahanNOAA
Copy link
Author

@EricJames-NOAA will have to answer that since he's the one who tested the workflow.

@hu5970
Copy link

hu5970 commented Sep 22, 2022

@EricJames-NOAA Eric, I don't see any problem but please review and approve this one if you are OK with it.
Thanks, Ming

Copy link

@EricJames-NOAA EricJames-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hu5970 hu5970 merged commit d9ede3f into NOAA-GSL:feature/RRFS_dev1 Sep 26, 2022
guoqing-noaa pushed a commit to guoqing-noaa/regional_workflow that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants