Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gsl/develop from main 20210721 #16

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Jul 21, 2021

Update gsl/develop from main as of 2021/07/21. All code has been reviewed and tested before it was merged into the authoritative repository.

Changes in this PR:

  • support for scheme subcycling in framework

Associated PRs:

NOAA-GSL/stochastic_physics#8
#16
NOAA-GSL/ccpp-physics#100
NOAA-GSL/fv3atm#102
NOAA-GSL/ufs-weather-model#96

For regression testing, see NOAA-GSL/ufs-weather-model#96

@DomHeinzeller
Copy link

@SamuelTrahanNOAA did you want to review this set of "update from the authoritative repository" PRs or should I merge it w/o approval, since all these changes have been reviewed previously and the regression tests passed/failed as expected? Thanks!

Associated PRs:

NOAA-GSL/stochastic_physics#8
#16
NOAA-GSL/ccpp-physics#100
NOAA-GSL/fv3atm#102
NOAA-GSL/ufs-weather-model#96

For regression testing, see NOAA-GSL/ufs-weather-model#96

@SamuelTrahanNOAA
Copy link
Collaborator

I approved, but it seems @climbfuji is still waiting for @DomHenzeller to approve his changes.

@DomHeinzeller DomHeinzeller merged commit fc8b186 into NOAA-GSL:gsl/develop Jul 27, 2021
@DomHeinzeller
Copy link

I approved, but it seems @climbfuji is still waiting for @DomHenzeller to approve his changes.

:-) Thanks a lot! I am not going to self-approve.

@climbfuji climbfuji deleted the update_gsl_develop_from_main_20210721 branch June 27, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants