Modifications to exp2 ceiling diagnostic for RRFS #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeolson42
reviewed
Dec 15, 2022
| @@ -2190,23 +2197,24 @@ SUBROUTINE CLDRAD | |||
| end do | |||
| !-- end of search 2 | |||
|
|
|||
| zceil = min(zceil1,zceil2) ! choose lower of zceil1 and zceil2 | |||
| ! zceil = min(zceil1,zceil2) ! choose lower of zceil1 and zceil2 | |||
There was a problem hiding this comment.
Is zceil2 from the summation principle? Is that why it's ignored?
There was a problem hiding this comment.
@joeolson42 Yes, the preceding lines define zceil2 which is from the summation principle.
joeolson42
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the exp2 ceiling diagnostic for RRFS. The cloud fraction threshold has been increased from 0.4 to 0.5, and several "add-ons", useful for correcting the HRRR's underprediction of clouds, have been commented out, including (1) the summation principle (achieved by ignoring the zceil2 calculated using the summation principle) and (2) the lowering of ceilings due to falling snow.
If anyone wants to look at the sample maps from RRFS_CONUS before and after the change, I can share those. The revision increases ceiling height, as expected. The code was tested in both RRFS_CONUS_3km and RRFS_NA_3km on Jet.
Old formulation of exp2:
ndata=1905141:undef=0:mean=9393.89:min=28.5117:max=20000
Revised formulation of exp2:
ndata=1905141:undef=0:mean=10314.5:min=28.5117:max=20000