Fix issue #1 the apparent hang in writing the trajectories #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Model run apparently hangs at the end when trying to write icebergs trajectories This is not an i/o issue but due to the root pe (or io_tile_root_pes) traversing a linked list of millions of nodes. It just take a long long time. - This fix "push"es the nodes at the top of the list instead of trying to find the tail to append it. The list will be in reverse order and has to be reversed before writing to file.
|
Assigned to @adcroft for review. |
- Timings show that in long run simulations writing one trajectory file per tile io has a sever impact on model timing. Specifically Termination time can become larger than the Main loop time. - This update bypasses using the io_layout for trajectory files and forces one file per processor (the way old iceberg model behaved till ulm) by setting a namelist icebergs_nml: force_all_pes_traj = .true. - This is a temporary fix to let people run long run simulations until we find a proper fix.
adcroft
pushed a commit
to adcroft/icebergs
that referenced
this pull request
Jan 5, 2023
Changes default value of cdrag_grounding
adcroft
pushed a commit
to adcroft/icebergs
that referenced
this pull request
Jan 6, 2023
Changes default value of cdrag_grounding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a linked list of millions of nodes. It just take a long long time and the model times out.
-The list will be in reverse order and has to be reversed before writing to file.