Make icebergs use the mask_table #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The maskmap argument was commented out (inherted from sis1).
- There will be "bad lon" , "bad lat" warnings in the stderr because
lon and lat for bergs are not being initialized over the masking area.
- My previous commit to make icebergs use mask_table broke models that do not have a mask_table. This was due to unassociated maskmap being passed to mpp_define_domains. - mpp_define_domains has an optional argument called "maskmap" that should be associated. We are relying on the compiler to not pass this argument if it is itself a ".not. present" optional argument! - Made the optional argument maskmap to be the last argument of iceberg_init for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icebergs need to use the mask_table whenever SIS2 does. and SIS2 needs to use it for OM4_SIS2 experiments.