User/nnz/port tom ice ridging #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The original work was done in ice_sis on top of a user branch ice_sis_perth2008_10_16dec2008_smg - CVS was not used for the development and Martin passed us a bunch of files with no validation tests. - The plan is to "port" these developments from ice_sis (in Perth) to sis2. A very tall order indeed. - This initial "port" compiles. But I have absolutely no expectations that it runs validly. - In fact I am not even sure if this won't break sis2 models. - There is much more effort (development and testing needed to make something healthy out of this branch. It is just a placeholder at this stage. - Also the whole development needs to be reviewed and vetted by Bob before merging into dev/master
Conflicts: Resolved ice_model.F90 ice_transport.F90 ice_type.F90
- The model now compiles on gaea and reproduces sis2 timestats
- ridging rate was calculated after ridging was done. The original TOM files does that by lagging the use of rdg_rate to next step. - corrected some uninitialized variables. - the model now runs in debug mode as well. - DO_RIDGING = True does not change timestats !!! Even though there is non-zero ridging rate over ice !
- Under GNU compiler the model crashes if input arrays are passed in with the explicit index ranges!
- ice age can be diagnosed by adding AGE to diag_table
adcroft
force-pushed
the
dev/master
branch
2 times, most recently
from
2c2168e to
7d300ff
Compare
|
This merge is now too old to merge efficiently, and the code that was introduced has already been ported into SIS2, so this pull request is being closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch tries to "port" the development of ridging scheme from Torge Martin in SIS1 into SIS2.
The model compiles and runs (in debug mode too). It reproduces dev/master timestats.
To turn on the scheme do a SIS_override with
DO_RIDGING = True
Without having a test case at hand I have no way to evaluate the scheme.
Even though it produces non-zero ridging rate, the timestat (after 1 day) is identical to the original (with DO_RIDGING = False)
This pull request needs critical review and evaluation!