+(*)Report heat stocks relative to liquid at 0 degC #163
+40
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised ice_stock_pe() to report the heat stock relative to liquid water at 0 degrees C, rather than just the heat required to melt the ice, as this gives a much more robust estimates of the enthalpy budget when sea ice salinities are allowed to vary. To help implement this, the new function energy_0degC was added to SIS2_ice_thm.F90. Several module use statements that were referring to unused routines from within SIS2_ice_thm were also redacted. All solutions are bitwise identical, but there are changes in the reported stock values, and there is a new publicly visible function.
MJHarrison-GFDL
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
In addition to some code cleanup and documentation, this change will allow for a more accurate accounting of enthalpy exchange between the sea-ice and ocean. Answers are not impacted, but as noted the stocks report (which is used within the FMS coupling framework) will change but these results are not being tracked in current MOM6 regression tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised ice_stock_pe() to report the heat stock relative to liquid water at 0
degrees C, rather than just the heat required to melt the ice, as this gives a
much more robust estimates of the enthalpy budget when sea ice salinities are
allowed to vary. To help implement this, the new function energy_0degC was
added to SIS2_ice_thm.F90. Several module use statements that were referring to
unused routines from within SIS2_ice_thm were also redacted. All solutions are
bitwise identical, but there are changes in the reported stock values, and there
is a new publicly visible function.