Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIS2 in SPECIFIED_ICE mode (used in AM4) does not reproduce across restarts #107

Closed
nikizadehgfdl opened this issue Aug 13, 2019 · 1 comment
Closed

SIS2 in SPECIFIED_ICE mode (used in AM4) does not reproduce across restarts #107

nikizadehgfdl opened this issue Aug 13, 2019 · 1 comment

Comments

@nikizadehgfdl
Copy link
Contributor

There is a push to replace SIS1 with SIS2 in AM4 workflow. The model runs, however it does not reproduce across restarts.

xml: /ncrc/home2/Niki.Zadeh/xmls/xanadu/mdt_xml_dev/ESM4_amip_sis2_D1.xml
exp: ESM4_amip_sis2_D1

FYI, it doesn't reproduce the AM4 answers with SIS1 either. After fixing this bug, we will need to make a long run to evaluate these new answers with SIS2.
nikizadehgfdl added a commit to nikizadehgfdl/SIS2 that referenced this issue Aug 20, 2019
@nikizadehgfdl
Fix for specified ice restart issue NOAA-GFDL#107
c086497 
- Variable Ice%sCS%OSS%SST_C is not an ice state and hence is not in ice_model.res.nc
  However for SPECIFIED_ICE=True it should be updated after restart, otherwise the model
  would have a restart issue (NOAA-GFDL#107)
  In specified ice this variable is read from data_table every time step. So that is also
  the easiest way to update it after a restart.
- This update resolves issue#107.
nikizadehgfdl added a commit to nikizadehgfdl/SIS2 that referenced this issue Aug 21, 2019
@nikizadehgfdl
Fix for specified ice restart issue NOAA-GFDL#107
9991d35 
- Variable Ice%sCS%OSS%SST_C is not an ice state and hence is not in ice_model.res.nc
      However for SPECIFIED_ICE=True it should be updated after restart, otherwise the model
      would have a restart issue (NOAA-GFDL#107)
      In specified ice this variable is read from data_table every time step. So that is also
      the easiest way to update it after a restart.
- This update resolves issue#107.

- Adding some indication that SIS2 is being restored from restart files.
  With input_filename being 'n' or 'r' having no effect there is no
  indication in stdout whether restart files are being read or not.
@nikizadehgfdl nikizadehgfdl mentioned this issue Aug 21, 2019
Merged
nikizadehgfdl added a commit to nikizadehgfdl/SIS2 that referenced this issue Nov 27, 2019
@nikizadehgfdl
Fix for specified ice restart issue NOAA-GFDL#107
226794e 
- Variable Ice%sCS%OSS%SST_C is not an ice state and hence is not in ice_model.res.nc
  However for SPECIFIED_ICE=True it should be updated after restart, otherwise the model
  would have a restart issue (NOAA-GFDL#107)
  In specified ice this variable is read from data_table every time step. So that is also
  the easiest way to update it after a restart.
- This update resolves issue#107.

- Adding some indication that SIS2 is being restored from restart files.
  With input_filename being 'n' or 'r' having no effect there is no
  indication in stdout whether restart files are being read or not.

- cleanup
Hallberg-NOAA added a commit that referenced this issue Dec 2, 2019
@Hallberg-NOAA
Merge pull request #109 from nikizadehgfdl/specified_ice_restart_fix
29e266d 
Fix for specified ice restart issue #107
@nikizadehgfdl
Copy link
Contributor Author

This is fixed in dev/gfdl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nikizadehgfdl