Change the default of VISC_REM_CONT_HVEL_FIX #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily cut off the control of VISC_REM_CONT_HVEL_FIX from VISC_REM_BUG and change the default of VISC_REM_CONT_HVEL_FIX to False.
Hallberg-NOAA
approved these changes
Sep 16, 2024
Hallberg-NOAA
added
bug
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24909 ✔️ |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VISC_REM_CONT_HVEL_FIX seems to be causing problems and requires further investigation.
This PR turns off VISC_REM_CONT_HVEL_FIX, by temporarily cutting off the control of VISC_REM_CONT_HVEL_FIX by VISC_REM_BUG. The default of VISC_REM_CONT_HVEL_FIX is now False. VISC_REM_BUG now only controls the default of VISC_REM_BT_WEIGHT_FIX and VISC_REM_TIMESTEP_FIX.