Correct 10 do-loop index cases #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #680 +/- ##
============================================
+ Coverage 37.07% 40.90% +3.82%
============================================
Files 271 42 -229
Lines 81988 5286 -76702
Branches 15292 1013 -14279
============================================
- Hits 30401 2162 -28239
+ Misses 45927 2939 -42988
+ Partials 5660 185 -5475 ☔ View full report in Codecov by Sentry. |
marshallward
approved these changes
Jul 12, 2024
Corrected the case of the do-loop index variable in 10 places in 6 files, initialized two whole diagnostic arrays to 0 instead of having shared loops initializing u- and v-point arrays, and shortened two loops initializing pressures to the size that is actually used in the corresponding equation of state calls. With these changes, there are no i- or j- loops with extents that are inconsistent with the stagger-based index case convention used throughout the MOM6 code. All answers are bitwise identical in all cases.
Hallberg-NOAA
force-pushed
the
loop_index_case_cleanup
branch
from
419e5f9 to
05a65ed
Compare
|
This PR passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24083. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the case of the do-loop index variable in 10 places in 6 files, initialized two whole diagnostic arrays to 0 instead of having shared loops initializing u- and v-point arrays, and shortened two loops initializing pressures to the size that is actually used in the corresponding equation of state calls. With these changes, there are no i- or j- loops with extents that are inconsistent with the stagger-based index case convention used throughout the MOM6 code. All answers are bitwise identical in all cases.