Autoconf: Disable LDFLAGS for C testing #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcroft
approved these changes
Jun 24, 2024
Certain compilers would expect values passed to ld which cannot be passed to the C compiler. This caused the autoconf C configuration to fail, since it uses to CC for linking rather than LD. Since we never use the C compiler for linking, this is not something we need to be concerned about, and the LDFLAGS is disabled when testing the C compiler. This is only a concern when using certain GPU-related flags in the Nvidia compiler, and is only a problem for libraries with a significant amount of C code, such as FMS.
Hallberg-NOAA
force-pushed
the
ac_no_c_ldflags
branch
from
75be1dd to
e483c23
Compare
|
This has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24040. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain compilers would expect values passed to ld which cannot be passed to the C compiler. This caused the autoconf C configuration to fail, since it uses to CC for linking rather than LD.
Since we never use the C compiler for linking, this is not something we need to be concerned about, and the LDFLAGS is disabled when testing the C compiler.
This is only a concern when using certain GPU-related flags in the Nvidia compiler, and is only a problem for libraries with a significant amount of C code, such as FMS.