Replace kind=8 with iso_fortran_env kinds #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces references to kind=8 with the corresponding Fortran kind identifiers as defined in iso_fortran_env. Although these are widely equal to 8, there are a number of compilers (notably NAG, also others) which set it to a different value. This improves the portability of the code (albeit in a rather minor way).
Hallberg-NOAA
approved these changes
Jun 5, 2024
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/24005 ✔️ (Parameter flag is from out-of-date files) |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces references to kind=8 with the corresponding Fortran kind identifiers as defined in iso_fortran_env.
Although these are widely equal to 8, there are a number of compilers (notably NAG, also others) which set it to a different value.
This improves the portability of the code (albeit in a rather minor way).