Correct the computation of FrictWork in MOM_hor_visc #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add FRICTWORK_BUG parameter (default is true). If FRICTWORK_BUG is false, use the new way to compute FrictWork using the thickness flux. The previous version (realized by setting FRICTWORK_BUG as true) uses the velocity to compute FrictWork, which overestimates the total energy dissipation rate compared with the domain integral of KE_horvisc computed in MOM_diagnostics.
Hallberg-NOAA
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
With the recent updates, this PR is now looking to me like it is ready to go. Thank you very much for this contribution, @Wendazhang33 .
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/jobs/132092 ✔️ 🟡 |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the computation of FrictWork in MOM_hor_visc.F90. The domain integral of FrictWork should exactly match the total energy dissipation rate by horizontal viscosity (KE_horvisc) computed in MOM_diagnostics. However, the previous version of FrictWork (realized by setting FRICTWORK_BUG = True, which is the default) overestimates the magnitude of total KE_horvisc. The new code (realized by setting FRICTWORK_BUG = False) fixes this issue by using the thickness flux rather than the velocity to compute FrictWork. The figure below shows a comparison between the domain integral of KE_horvisc (blue solid line) and FrictWork (dashed lines). Orange and green dashed lines show the FrictWork computed by the old and new codes, respectively. The new code computes the FrictWork that exactly matches KE_horvisc, while the old code does not.