+(*)Fix rotation of coupler_type variables #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-huth
approved these changes
May 29, 2024
This commit adds the necessary information about the turns of the model grid relative to the (unrotated) coupler_type data fields that are inside of the forcing type and surface_state type and are used with passive tracers, so that certain tracer packages can now be used with rotated grids. The previous version had problems where the model would not run when ROTATE_INTEX = True and the CFCs (and probably other passive tracers) were being used, as noted at NOAA-GFDL/issues/621. These problems have now been fixed. There are new calls to coupler_type_spawn() in allocate_forcing_by_ref() and allocate_surface_state() that manage the creation of the coupler_2d_bt_types for unrotated types based on information from their rotated counterparts. There is a new optional turns arguments to allocate_forcing_by_ref() and new optional sfc_state_in and turns arguments to allocate_surface_state(), and these are now being used in at least 6 places where unrotated temporary surface_state or forcing types are being set up. There are also new optional turns argument to extract_coupler_type_data() and set_coupler_type_data() that are used to deal with the fact that the internal data arrays in the coupler_bc_types are never rotated, unlike the other MOM6 arrays, because they have to be passed directly into the generic tracer code. These new turns arguments are used in 14 calls from various tracer packages, including in 6 calls from the OCMIP2_CFC code. There are 4 new calls to deallocate_surface_state() or deallocate_forcing_type() that were added to avoid (presumably minor) memory leaks when grid rotation is enabled. These new calls are in initialize_ice_shelf_fluxes(), shelf_calc_flux() and in the surface flux diagnostics section of step_MOM(). All answers are bitwise identical in any cases that worked previously, but some cases with grid rotation that previously were failing with cryptic error messages are now running successfully. There are new optional arguments to several publicly visible routines.
Hallberg-NOAA
force-pushed
the
rotate_coupler_type
branch
from
9d72eb2 to
dbb82e6
Compare
marshallward
approved these changes
Jun 5, 2024
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/23746 ✔️ |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the necessary information about the turns of the model grid relative to the (unrotated)
coupler_typedata fields that are inside of theforcingtype andsurface_statetype and are used with passive tracers, so that certain tracer packages can now be used with rotated grids. The previous version had problems where the model would not run whenROTATE_INTEX = Trueand the CFCs (and probably other passive tracers) were being used, as noted at /issues/621. These problems have now been fixed.There are new calls to
coupler_type_spawn()inallocate_forcing_by_ref()andallocate_surface_state()that manage the creation of thecoupler_2d_bt_typesfor unrotated types based on information from their rotated counterparts.There is a new optional
turnsargument toallocate_forcing_by_ref()and new optionalsfc_state_inandturnsarguments toallocate_surface_state(), and these are now being used in at least 6 places where unrotated temporarysurface_stateorforcingtypes are being set up.There are also new optional
turnsarguments toextract_coupler_type_data()andset_coupler_type_data()that are used to deal with the fact that the internal data arrays in thecoupler_bc_typesare never rotated, unlike the other MOM6 arrays, because they have to be passed directly into the generic tracer code. These new turns arguments are used in 14 calls from various tracer packages, including in 6 calls from the OCMIP2_CFC code.There are 4 new calls to
deallocate_surface_state()ordeallocate_forcing_type()that were added to avoid (presumably minor) memory leaks when grid rotation is enabled. These new calls are ininitialize_ice_shelf_fluxes(),shelf_calc_flux()and in the surface flux diagnostics section ofstep_MOM().All answers are bitwise identical in any cases that worked previously, but some cases with grid rotation that previously were failing with cryptic error messages are now running successfully. There are new optional arguments to several publicly visible routines.