Flux through static ice-shelf to icebergs/new diagnostics #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has a compile-time error: which needs to be addressed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/gfdl #622 +/- ##
============================================
- Coverage 37.04% 36.92% -0.13%
============================================
Files 271 271
Lines 81267 81416 +149
Branches 15162 15221 +59
============================================
- Hits 30109 30064 -45
- Misses 45517 45724 +207
+ Partials 5641 5628 -13 ☔ View full report in Codecov by Sentry. |
Hallberg-NOAA
approved these changes
May 31, 2024
Added variables for the accumulated iceberg mass and heat flux due to calving from ice shelves (flux through the static ice front). These will be passed to the coupler and SIS2/iceberg module to initialize bergs. Also fixed the ice-shelf SMB override and reorganized ice-shelf post data calls so that they do not strictly have to be called at multiples of the ice velocity time step.
Added ice-shelf scalar diagnostics related to volume-above-floatation and surface/basal mass balance. Had to modify ice-shelf diag mediator to allow scalar diagnostics.
…ove-floatation variable from 'vab' to 'vaf'
…lf so that it is passing the correct arguments
Hallberg-NOAA
force-pushed
the
MOM_PR_IS2berg
branch
from
28c66af to
f6e237c
Compare
|
This PR has passed pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/mom6ci/MOM6/-/pipelines/23682. |
Wendazhang33
pushed a commit
to Wendazhang33/MOM6-GFDL
that referenced
this pull request
Jun 3, 2024
) * Added option to convert flux through static ice front into icebergs Added variables for the accumulated iceberg mass and heat flux due to calving from ice shelves (flux through the static ice front). These will be passed to the coupler and SIS2/iceberg module to initialize bergs. Also fixed the ice-shelf SMB override and reorganized ice-shelf post data calls so that they do not strictly have to be called at multiples of the ice velocity time step. * Added ice-shelf scalar diagnostics Added ice-shelf scalar diagnostics related to volume-above-floatation and surface/basal mass balance. Had to modify ice-shelf diag mediator to allow scalar diagnostics. * Fixed units for volume-above-floatation and Cp_ice. Renamed volume-above-floatation variable from 'vab' to 'vaf' * Fixed write_ice_shelf_energy call within subroutine solo_step_ice_shelf so that it is passing the correct arguments * Fixed syntax of calving units * Fixed units for ice shelf calving and scalar diagnostics
c2xu
pushed a commit
to c2xu/MOM6
that referenced
this pull request
Jun 11, 2024
) * Added option to convert flux through static ice front into icebergs Added variables for the accumulated iceberg mass and heat flux due to calving from ice shelves (flux through the static ice front). These will be passed to the coupler and SIS2/iceberg module to initialize bergs. Also fixed the ice-shelf SMB override and reorganized ice-shelf post data calls so that they do not strictly have to be called at multiples of the ice velocity time step. * Added ice-shelf scalar diagnostics Added ice-shelf scalar diagnostics related to volume-above-floatation and surface/basal mass balance. Had to modify ice-shelf diag mediator to allow scalar diagnostics. * Fixed units for volume-above-floatation and Cp_ice. Renamed volume-above-floatation variable from 'vab' to 'vaf' * Fixed write_ice_shelf_energy call within subroutine solo_step_ice_shelf so that it is passing the correct arguments * Fixed syntax of calving units * Fixed units for ice shelf calving and scalar diagnostics
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added variables for the accumulated iceberg mass and heat flux due to calving from ice shelves (flux through the static ice front). These variables will be passed to the coupler and SIS2/iceberg module to initialize bergs.
See related changes in:
Coupler: alex-huth/FMScoupler@3e80bbc
SIS2: NOAA-GFDL/SIS2#209
It was easiest to tag a few other changes onto this PR as well:
-fixed the ice-shelf SMB override
-reorganized ice-shelf post data calls so that they do not strictly have to be called at multiples of the ice velocity time step.
-Added ice-shelf scalar diagnostics related to volume-above-floatation and surface/basal mass balance.