Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for https://github.com/mom-ocean/MOM6/issues/1572 #142

Closed
wants to merge 1 commit into from

Conversation

sanAkel
Copy link

@sanAkel sanAkel commented Jun 7, 2022

(Originally sent to mom-ocean#1573, closing there in favor of here.)

This PR fixes mom-ocean#1572 with a simple fix.

✅ Verified that VERBOSITY = 9 runs through.

For reference, my MOM_parameter_doc.all and MOM_parameter_doc.debugging are included. (For compiler and its flags please see mom-ocean#1572 (comment); my build is debug type.)

Thanks for reviewing.

MOM_parameter_doc.all 6.55.43 PM.txt
MOM_parameter_doc.debugging 6.55.43 PM.txt

@sanAkel sanAkel force-pushed the fix_for_issue_1572 branch from c442fc5 to f1a381a Compare June 7, 2022 01:58
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #142 (f1a381a) into dev/gfdl (4288d41) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##           dev/gfdl     #142      +/-   ##
============================================
- Coverage     33.45%   33.45%   -0.01%     
============================================
  Files           262      262              
  Lines         71413    71414       +1     
  Branches      13336    13336              
============================================
  Hits          23891    23891              
- Misses        43048    43049       +1     
  Partials       4474     4474              
Impacted Files Coverage Δ
src/framework/MOM_unique_scales.F90 6.17% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4288d41...f1a381a. Read the comment docs.

@sanAkel
Copy link
Author

sanAkel commented Jun 7, 2022

@marshallward, I guess this works? Since you closed the other one in mom-ocean.

I am un drafting it.

@sanAkel sanAkel marked this pull request as ready for review June 7, 2022 14:52
Copy link
Member

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This targeted change should neatly address the problem noted at mom-ocean#1572. Thank you for this quick bug-fix, @sanAkel!

@sanAkel
Copy link
Author

sanAkel commented Jun 7, 2022

This targeted change should neatly address the problem noted at mom-ocean#1572. Thank you for this quick bug-fix, @sanAkel!

Thank you @Hallberg-NOAA I wasn't sure if you would like that number! 😄

@marshallward
Copy link
Member

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15925 ✔️

@marshallward
Copy link
Member

A rebased version of this commit was merged into dev/gfdl (79eb807).

@sanAkel sanAkel deleted the fix_for_issue_1572 branch June 20, 2022 19:17
marshallward pushed a commit that referenced this pull request Feb 3, 2025
update to main repo. 20250113 commit (20241127-PR)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verbosity level in MOM_unique_scales.F90
3 participants