-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for https://github.com/mom-ocean/MOM6/issues/1572 #142
Conversation
…ique_scales before returning
c442fc5
to
f1a381a
Compare
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #142 +/- ##
============================================
- Coverage 33.45% 33.45% -0.01%
============================================
Files 262 262
Lines 71413 71414 +1
Branches 13336 13336
============================================
Hits 23891 23891
- Misses 43048 43049 +1
Partials 4474 4474
Continue to review full report at Codecov.
|
@marshallward, I guess this works? Since you closed the other one in mom-ocean. I am un drafting it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This targeted change should neatly address the problem noted at mom-ocean#1572. Thank you for this quick bug-fix, @sanAkel!
Thank you @Hallberg-NOAA I wasn't sure if you would like that number! 😄 |
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/15925 ✔️ |
A rebased version of this commit was merged into dev/gfdl (79eb807). |
update to main repo. 20250113 commit (20241127-PR)
(Originally sent to mom-ocean#1573, closing there in favor of here.)
This PR fixes mom-ocean#1572 with a simple fix.
✅ Verified that VERBOSITY = 9 runs through.
For reference, my MOM_parameter_doc.all and MOM_parameter_doc.debugging are included. (For compiler and its flags please see mom-ocean#1572 (comment); my build is debug type.)
Thanks for reviewing.
MOM_parameter_doc.all 6.55.43 PM.txt
MOM_parameter_doc.debugging 6.55.43 PM.txt