Fix virtual potential temperature in the total energy calculation #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix virtual potential temperature (Tv) in the total energy calculation (TE) when hydrostatic=.T. and -DUSE_COND compiling flag on.
This change will not impact non-hydrostatic runs and hydrostatic run with -DUSE_COND flag off.
The "condensate" modification part of Tv is added when -DUSE_COND is on for hydrostatic runs in order to have consistent TE calculation in fv_dynamics.F90 and fv_mapz.F90.
Note that the hydrostatic solver might not function correctly with USE_COND and/or MOIST_CAPPA in other places. Additional testing may be required.
How Has This Been Tested?
It was tested on Orion for SHiELD.
Checklist:
Please check all whether they apply or not