Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix fv_regional_bc.F90: initialize cloud amount boundary conditions only if cloud amount is a valid tracer #146

Conversation

DomHeinzeller
Copy link

Description

As the title says. In model/fv_regional_bc.F90, initialize cloud amount boundary conditions to zero only if cloud amount is a valid tracer (i.e. if the index in the tracer array is > 0).

Fixes #145

Tested in the latest ufs-weather-model for regression tests that are run only sporadically (rt_ccpp_dev.conf), i.e. not as part of the standard Intel/GNU tests. This solves a crash with old input data that was generated for Thompson MP and doesn't have cloud amount.

Checklist:

Please check all whether they apply or not

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [n/a] I have commented my code, particularly in hard-to-understand areas
  • [n/a] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • [n/a] Any dependent changes have been merged and published in downstream modules

…ions to zero only if cloud amount is being used by this model run
@DomHeinzeller
Copy link
Author

I don't know what GitHub was doing, but this issue has not been solved yet. Reopening.

@laurenchilutti laurenchilutti merged commit 43e215b into NOAA-GFDL:dev/emc Oct 6, 2021
laurenchilutti added a commit that referenced this pull request Oct 6, 2021
…ud_amount

Bug fix fv_regional_bc.F90: initialize cloud amount boundary conditions only if cloud amount is a valid tracer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants