Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change diag output yaml name #1646

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Feb 18, 2025

Description
Changes the name of the output yaml table from diag_out.yaml to diag_manifest.yaml.

The change in diag_manager.F90 is just fixing a uninitialized return value that was setting off a runtime check.

How Has This Been Tested?
make check on the amd box

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

uramirez8707
uramirez8707 previously approved these changes Feb 25, 2025
@rem1776 rem1776 changed the base branch from main to release/2025.01 February 25, 2025 17:57
@rem1776 rem1776 dismissed uramirez8707’s stale review February 25, 2025 17:57

The base branch was changed.

@rem1776 rem1776 requested a review from bensonr as a code owner February 25, 2025 17:57
@bensonr
Copy link
Contributor

bensonr commented Feb 25, 2025

@rem1776 - is the intent to write out the input diag_table as a yaml? Or is it to list what variables will be output as part of a run - basically a catalog?

@rem1776
Copy link
Contributor Author

rem1776 commented Feb 25, 2025

This is only for the diag_manager rewrite, so it's mainly to show what was read in from the diag_table.yaml plus any additional information we may want for post processing.

@rem1776 rem1776 merged commit d458e40 into NOAA-GFDL:release/2025.01 Feb 26, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants