Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern Diag Manager:: Repro fixes #1435

Merged
merged 7 commits into from
Jan 18, 2024

Conversation

uramirez8707
Copy link
Contributor

@uramirez8707 uramirez8707 commented Dec 29, 2023

Description

  • Add the set_name to the axis object and use it when searching the compress dimension.
    The set name is used to distinguish axis with the same name and it is used in the land code. For example,
    https://gitlab.gfdl.noaa.gov/fms/lm4P/-/blob/2023.02/land_model.F90?ref_type=tags#L3863-3887
  • Adds the "associated_files" global attribute to files that need (i.e when the "area" or "volume" variables are not in the file)
    This attribute is needed for PP/fregrid
  • If a long_name is not set, use the variable name (instead of out_name) to be consistent with the old diag manager
  • Skip diag fields that do not have any data

Fixes # (issue)

How Has This Been Tested?
CI

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@uramirez8707 uramirez8707 changed the title Modern Diag Manager:: set_name Modern Diag Manager:: Repro fixes Jan 17, 2024
@uramirez8707 uramirez8707 marked this pull request as ready for review January 17, 2024 19:33
@uramirez8707 uramirez8707 requested a review from rem1776 January 17, 2024 19:33
@thomas-robinson thomas-robinson merged commit 1660eac into NOAA-GFDL:dmUpdate Jan 18, 2024
19 checks passed
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
* Add the set_name to the axis object and use it when searching the compress dimension

* in the case where the longname is not given, use the varname instead of output name

* Add the associated_files global attribute if needed
---
Co-authored-by: Uriel Ramirez <[email protected]>
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
* Add the set_name to the axis object and use it when searching the compress dimension

* in the case where the longname is not given, use the varname instead of output name

* Add the associated_files global attribute if needed
---
Co-authored-by: Uriel Ramirez <[email protected]>
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
rem1776 pushed a commit to rem1776/FMS that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants