Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fortran header file extenstions from .h to .fh #1087

Merged
merged 18 commits into from
Dec 23, 2022

Conversation

mcallic2
Copy link
Contributor

@mcallic2 mcallic2 commented Dec 7, 2022

Description
This changes the extension names from .h to .fh for fortran header files within FMS. It also changes any calls to the header files.

Fixes #1096

How Has This Been Tested?
Testes with autotools using oneapi and cmake
@rem1776 @underwoo

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@mcallic2 mcallic2 marked this pull request as draft December 8, 2022 13:20
@mcallic2 mcallic2 marked this pull request as ready for review December 14, 2022 14:47
Copy link
Contributor

@rem1776 rem1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just needs the doxygen fix i left the comment about in a few spots

@thomas-robinson
Copy link
Member

@mcallic2 You need to link an issue for this.

@rem1776 rem1776 merged commit 203c8bf into NOAA-GFDL:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename fortran header extensions
3 participants