On ppan, use hsmget to copy model files before opening #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwagura
approved these changes
Feb 13, 2025
|
|
||
| def __call__(self, path_or_paths): | ||
| if which('hsmget') is None or not self._dirs_exist(): | ||
| # If hsmget or /archive, /ptmp, etc are not available, this will just return the input path(s). |
There was a problem hiding this comment.
Since this assumes the user has already module loaded hsmget, maybe we should tell the user somewhere to run that command beforehand if they want to use hsmget?
There was a problem hiding this comment.
Good idea! I added a reminder to the log message, a comment, and a note in the README.
yichengt900
reviewed
Feb 13, 2025
| return xarray.open_mfdataset(files)[var] | ||
| # For now, replicate previous behavior by looking for a single file covering 1993--2019, | ||
| # and if not found then looking for multiple files written in either yearly or 5-yearly chunks. | ||
| # Later this can be replaced to more intelligently look for the right file(s). |
There was a problem hiding this comment.
I like this comment intelligently look for the right file(s) : )
There was a problem hiding this comment.
I have a PR ready for once this one is merged 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR to build towards working with an updated historical simulation. This one adds a wrapper around the
hsmgettool and uses it in theopen_varfunction so that model data is opened from /vftmp instead of /archive.The general usage is
If the above is run on ppan, it will copy the file from archive to
/ptmp/$USER/archive/acr/fre/NWA/2025_01/NWA12_COBALT_2025_01/gfdl.ncrc6-intel23-prod-hdf5/pp/ocean_monthly/ts/monthly/5yr/ocean_monthly.199301-199712.ssh.ncAnd then from there to
/vftmp/$USER/pid####/archive/acr/fre/NWA/2025_01/NWA12_COBALT_2025_01/gfdl.ncrc6-intel23-prod-hdf5/pp/ocean_monthly/ts/monthly/5yr/ocean_monthly.199301-199712.ssh.ncFinally it will return the above /vftmp path as a
Path.Future runs of the script from the same ppan session will use the vftmp file immediately. Otherwise, the file will be quickly copied from ptmp as long as that hasn't been swept.
The biggest advantage of this function would be to work with the raw history files, since frepp will also cache those files in the same place on /ptmp. It's still an improvement to not read the post-processed files directly from archive, though.
If the hsmget module isn't loaded or the script isn't running on ppan,
hsmget()should just do nothing and directly return the input path(s), allowing them to be opened as usual.