Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the nceppost with request by using the 10.0.0 version #31

Closed
Hang-Lei-NOAA opened this issue Oct 20, 2020 · 11 comments · Fixed by #92
Closed

Update the nceppost with request by using the 10.0.0 version #31

Hang-Lei-NOAA opened this issue Oct 20, 2020 · 11 comments · Fixed by #92
Labels
enhancement New feature or request

Comments

@Hang-Lei-NOAA
Copy link
Contributor

Wen has added the nceppost with UPP version of 10.0.0. She request the installation test through hpc-stack.
We will first try it from the EMC_POST/develop branch, on each machine.
If it is okay, she needs to create a release to formally included in the hpc-stack.

A branch has been created to this issue
feature/postupdate

@kgerheiser
Copy link
Contributor

What exactly is the problem?

@aerorahul
Copy link
Contributor

EMC_Post is built as nceppost in hpc-stack. The library it builds is called libnceppost.a and the module files export the variable nceppost_ROOT so that the UFS can find it via find_package(nceppost).

EMC_Post is now producing the library as libupp.a. nceppost was always going to be temporary stop gap measure until EMC_Post finalized what they want the library (and executable) to be called. We also did not know what versioning they would adopt (if any).

It appears that they have now adopted the name upp in their library libupp.a and upp.x for the executable.
Also, they seem to have settled on a version number 10.0.0 for EMC_post (or UPP).

How does this affect hpc-stack?
One needs to:

  1. add upp along side ncepppst in build_nceplib.sh
  2. add a modulefile for upp similar to nceppost, but the variable we need in there is only upp_ROOT. All other POST_LIB etc can be purged, because there is no need for them or an update is needed in the Makefiles to use libupp.a. They can key on upp_ROOT. This makes management of the modulefile simpler and cleaner.
  3. update the yaml files to add a section on upp.

For an example see https://github.com/aerorahul/hpc-stack/tree/feature/upp

@Hang-Lei-NOAA
Copy link
Contributor Author

Hang-Lei-NOAA commented Nov 16, 2020 via email

@edwardhartnett
Copy link
Contributor

Have these changes been merged to develop?

@Hang-Lei-NOAA
Copy link
Contributor Author

Hang-Lei-NOAA commented Nov 19, 2020 via email

@edwardhartnett
Copy link
Contributor

OK, I will close this issue.

@edwardhartnett edwardhartnett added the enhancement New feature or request label Nov 19, 2020
@edwardhartnett
Copy link
Contributor

I thought this had been completed, but apparently not?

@Hang-Lei-NOAA
Copy link
Contributor Author

Hang-Lei-NOAA commented Nov 19, 2020 via email

@edwardhartnett
Copy link
Contributor

@Hang-Lei-NOAA see comments in #63

@Hang-Lei-NOAA
Copy link
Contributor Author

Hang-Lei-NOAA commented Nov 19, 2020 via email

@aerorahul
Copy link
Contributor

not just macOS. Also on ubuntu and mpich. See the other log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants