Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update enkf archive jobs to use COMIN/COMOUT #3393

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Update enkf archive jobs to use COMIN/COMOUT #3393

wants to merge 5 commits into from
+2 −4

Conversation

mingshichen-noaa
Copy link
Contributor

Description

NCO has requested that each COM variable specify whether it is an input or an output. This completes that process for the global JGDAS_ENKF_ARCHIVE_TARS and JGDAS_ENKF_ARCHIVE_VRFY jobs and associated bash and python scripts

Refs #2451

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO

How has this been tested?

  • Clone and build on RDHPCS
  • Cycled tests on Hercules
  • Forecast-only tests on Hercules

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • I have made corresponding changes to the documentation if necessary

DavidHuber-NOAA
DavidHuber-NOAA requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COM_TOP should not have been in the archive jobs to begin with, so please just go ahead and delete them. Changes look good otherwise.

jobs/JGDAS_ENKF_ARCHIVE_TARS Outdated
Comment on lines 10 to 11
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \
COMIN_TOP:COM_TOP_TMPL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the archive scripts and config files, I do not see any references to COM*TOP, so I think I put this in here by accident. Instead of renaming this to COMIN_TOP, let's just get rid of the variable.

Suggested change
YMD=${PDY} HH=${cyc} declare_from_tmpl -rx \
COMIN_TOP:COM_TOP_TMPL

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavidHuber-NOAA
I agree with your comments. I have removed COM*TOP variables.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was a holdover from before the cleanup job was broken out.

DavidHuber-NOAA
DavidHuber-NOAA approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Approve pending successful CI testing.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Feb 27, 2025
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules labels Feb 27, 2025
KateFriedman-NOAA
KateFriedman-NOAA approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks @mingshichen-noaa ! Approve pending successfully completion of CI tests.

@emcbot emcbot added CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress and removed CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules labels Feb 27, 2025
@mingshichen-noaa
Copy link
Contributor Author

@DavidHuber-NOAA
After I removed the variable--COM_TOP, I have made building and taken CI PR tests in Hercules. Testing statuses of all tasks are successful. Please refer to testing status at /work2/noaa/global/mchen/test/jobs/JGDAS_ENKF_ARCHIVE_TARS_VRFY/EXPDIR/C96C48_hybatmDA

@WalterKolczynski-NOAA WalterKolczynski-NOAA changed the title Feature/jgdas enkf archive tars vrfy Update enkf archive jobs to use COMIN/COMOUT Feb 27, 2025
@emcbot emcbot added CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Feb 27, 2025
@emcbot
Copy link

emcbot commented Feb 27, 2025

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3393


Experiment C96mx100_S2S_5b0aaeb3 Completed 1 Cycles: *SUCCESS* at Thu Feb 27 10:20:19 CST 2025
Experiment C48_ATM_5b0aaeb3 Completed 1 Cycles: *SUCCESS* at Thu Feb 27 10:44:33 CST 2025
Experiment C48mx500_hybAOWCDA_5b0aaeb3 Completed 2 Cycles: *SUCCESS* at Thu Feb 27 11:15:35 CST 2025
Experiment C96C48_hybatmDA_5b0aaeb3 Completed 3 Cycles: *SUCCESS* at Thu Feb 27 11:57:18 CST 2025
Experiment C96_atm3DVar_5b0aaeb3 Completed 3 Cycles: *SUCCESS* at Thu Feb 27 12:09:25 CST 2025
Experiment C48_S2SW_5b0aaeb3 Completed 1 Cycles: *SUCCESS* at Thu Feb 27 12:39:44 CST 2025
Experiment C48_S2SWA_gefs_5b0aaeb3 Completed 1 Cycles: *SUCCESS* at Thu Feb 27 13:48:16 CST 2025
Experiment C48mx500_3DVarAOWCDA_5b0aaeb3 Completed 2 Cycles: *SUCCESS* at Thu Feb 27 13:53:02 CST 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KateFriedman-NOAA KateFriedman-NOAA KateFriedman-NOAA approved these changes

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@WalterKolczynski-NOAA WalterKolczynski-NOAA Awaiting requested review from WalterKolczynski-NOAA

Assignees
No one assigned
Labels
CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mingshichen-noaa @emcbot @WalterKolczynski-NOAA @KateFriedman-NOAA @DavidHuber-NOAA