Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for syndat_getjtbul code parsing 3-character storm names (GFSv16.3.21) #3200

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix for syndat_getjtbul code parsing 3-character storm names (GFSv16.3.21) #3200

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6705417
Update for syndat_getjtbul code
KateFriedman-NOAA Jan 3, 2025
1cee9a0
Update comments related to number of year digits
KateFriedman-NOAA Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion docs/Release_Notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ GFS V16.3.21 RELEASE NOTES
PRELUDE
-------

The WAFS is separated from the GFS and is now its own package in production as WAFS.v7.0.1.
The WAFS is separated from the GFS and is now its own package in production as WAFS.v7.0.1. A code update for syndat_getjtbul is also included.

IMPLEMENTATION INSTRUCTIONS
---------------------------
Expand Down Expand Up @@ -60,6 +60,9 @@ The `sorc/build_all.sh` script no longer builds the WAFS code.
The `sorc/build_gfs_wafs.sh` build script is deleted.
The `sorc/link_fv3gfs.sh` script no longer links/copies WAFS files/execs.

Also included in this package is a fix to the syndat_getjtbul code to resolve a
parsing problem with 3-character storm names.

JOBS CHANGES
------------

Expand Down Expand Up @@ -190,3 +193,4 @@ PREPARED BY
[email protected]
[email protected]
[email protected]
[email protected]
12 changes: 10 additions & 2 deletions sorc/syndat_getjtbul.fd/getjtbul.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,21 @@ PROGRAM SYNDAT_GETJTBUL
END IF
END DO

IF(INL1(26).EQ.' '.or.INL1(27).EQ.' ') THEN
IF(INL1(25).EQ.' '.or.INL1(26).EQ.' '.or.INL1(27).EQ.' ') THEN

c ... THIS RECORD STILL CONTAINS THE OLD 2-DIGIT FORM OF THE YEAR -
c ... THIS PROGRAM WILL NOW CONVERT THE RECORD TO A 4-DIGIT YEAR USING
c THE "WINDOWING" TECHNIQUE SINCE SUBSEQUENT LOGIC EXPECTS THIS

IF(INL(18:19).EQ.'20') THEN
IF(INL(17:18).EQ.'20') THEN
DUMY2K(1:16) = INL(1:16)
DUMY2K(17:19) = ' '
DUMY2K(20:80) = INL(17:77)
INL= DUMY2K
PRINT *, ' '
PRINT *, '==> This is an new-format record with a 4-digit '
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor note. This should probably read

            PRINT *, '==> This is a new-format record with a 4-digit year'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment @DavidHuber-NOAA ! @Qingfu-Liu shall I make the suggested change from Dave?

PRINT *, ' '
ELSE IF(INL(18:19).EQ.'20') THEN
DUMY2K(1:17) = INL(1:17)
DUMY2K(18:19) = ' '
DUMY2K(20:80) = INL(18:78)
Expand Down