Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upadte and tested CI Bash for WCOSS2 #2481

Merged

Conversation

TerrenceMcGuinness-NOAA
Copy link
Collaborator

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA commented Apr 12, 2024

Description

Updates to the driver scripts to the CI framework to work on WCOSS with Cron Bash.

Resolves #2268

Type of change

  • Maintenance (extends CI testing framework to include WCOSS2)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? YES/NO

How has this been tested?

Tested with a PR that tested an end to end in cron on WCOSS2 with a fail that may be intrinsic of the branch's issues with the build there

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added the CI/CD Issue related to CI/CD label Apr 12, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA marked this pull request as ready for review April 15, 2024 21:09
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA changed the title Upadte CI Bash for WCOSS2 (basic) Upadte and tested CI Bash for WCOSS2 Apr 15, 2024
Copy link
Contributor

@WalterKolczynski-NOAA WalterKolczynski-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -u build option will need to be disabled on WCOSS and all of the tests that use JEDI will need to likewise be disabled. Otherwise this looks fine.

tmcguinness and others added 3 commits April 16, 2024 17:19
… build as for now only wcoss2 will be using the bash ci
trailing space at end of file
@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit b7e5b6e into NOAA-EMC:develop Apr 16, 2024
4 checks passed
danholdaway added a commit to danholdaway/global-workflow that referenced this pull request Apr 17, 2024
* upstream/develop:
  Add rocoto `sh` tag, script to check netcdf file and apply this to check ocean output (NOAA-EMC#2484)
  Revert file name changes in off-line post (NOAA-EMC#2499)
  Add mean/spread for atmos grib2 (NOAA-EMC#2482)
  Upadte and tested CI Bash for WCOSS2 (NOAA-EMC#2481)
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA deleted the ci_bash_wcoss2 branch April 30, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Issue related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI BASH system on WCOSS
2 participants