Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gfsv16b #147

Closed
wants to merge 13 commits into from
Closed

Feature/gfsv16b #147

wants to merge 13 commits into from

Conversation

GuangPingLou-NOAA
Copy link
Contributor

Add 6 bufr stations to the bufr sounding output per requests from Thailand Meteorological Department. This corresponds to Issue #142.
Change module paths from dev to prod for bufr sounding package and this relates to issue #145.

Copy link
Contributor

@yangfanglin yangfanglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for me

@yangfanglin
Copy link
Contributor

There is a conflict now. You need to resolve it.

Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kate requested this PR be deleted and a new PR be opened to merge these changes into feature/gfsv16b_updates.

@GuangPingLou-NOAA
Copy link
Contributor Author

GuangPingLou-NOAA commented Oct 5, 2020 via email

@GuangPingLou-NOAA
Copy link
Contributor Author

Kate, in the current PR, it says there is a conflict need to be resolved. If I open another PR to feature/gfsv16b_updates, do I have resolve this conflict first? Or just open a PR and use my current Fork.

@KateFriedman-NOAA
Copy link
Member

@GuangPingLou-NOAA Please sync your fork's branch with feature/gfsv16b_updates, resolve any conflicts in your sync merge on your end and then submit the PR to feature/gfsv16b_updates. Thanks!

See guidance on syncing your branch if needed here:
https://github.com/NOAA-EMC/global-workflow/wiki/Development-of-global-workflow#how-to-sync-fork-with-the-authoritative-repository

kayeekayee pushed a commit to kayeekayee/global-workflow that referenced this pull request May 30, 2024
…0/07/21) (NOAA-EMC#147)

- remove `include ./depend` from several GNU makefiles (from @DusanJovic-NOAA)
- correct CCPP version number in several suite definition files
- GFS_typedefs.F90: allow using `iopt_snf == 4` for other microphysics schemes than GFDL MP (required for RRFS, needs NoahMP and Thompson)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants