Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins pipeline does not fail when build_compute.sh all fails #3296

Closed
TerrenceMcGuinness-NOAA opened this issue Feb 4, 2025 · 0 comments · Fixed by #3297, #3298 or #3301
Closed

Jenkins pipeline does not fail when build_compute.sh all fails #3296

TerrenceMcGuinness-NOAA opened this issue Feb 4, 2025 · 0 comments · Fixed by #3297, #3298 or #3301
Assignees
@TerrenceMcGuinness-NOAA
Labels
bug Something isn't working CI/CD Issue related to CI/CD triage Issues that are triage

Comments

@TerrenceMcGuinness-NOAA
Copy link
Collaborator

What is wrong?

When there is a fail on a compute build job in the pipeline it should flag the CI as a fail and capture any appropriate log files as it did before compute builds.

What should have happened?

We should get an Fail label on the PR when a CI tests fails build, specifically a compute build as jobs.

What machines are impacted?

Hera, Orion, Hercules

What global-workflow hash are you using?

develop

Steps to reproduce

Already reproduced on build when it timed out

Additional information

No response

Do you have a proposed solution?

Update the pipeline code with a try block in just the right place
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added bug Something isn't working CI/CD Issue related to CI/CD triage Issues that are triage labels Feb 4, 2025
Merged
3 tasks
WalterKolczynski-NOAA pushed a commit that referenced this issue Feb 4, 2025
@TerrenceMcGuinness-NOAA
Capture build fail in Jenkins pipeline when no error logs are produced (
eee404c 
#3297)

The catch block for a build fail in the Jenkins pipeline did not capture
the case when there are no error logs produced.
This is has been rectified with this update. The compute build shell
script still could be enhanced by creating a `error.log` file in the log
directory.

Resolves #3296
@DavidHuber-NOAA DavidHuber-NOAA mentioned this issue Feb 4, 2025
Merged
22 tasks
aerorahul added a commit that referenced this issue Feb 5, 2025
@DavidHuber-NOAA @aerorahul
Increase the GDASApp build wallclock (#3298)
3d6c13e 
This increases the build wallclock and number of cores on compute build for the GDASApp to prevent CI
timeouts.

Resolves #3296 

---------

Co-authored-by: Rahul Mahajan <[email protected]>
@DavidHuber-NOAA DavidHuber-NOAA mentioned this issue Feb 5, 2025
Merged
9 tasks
aerorahul pushed a commit that referenced this issue Feb 10, 2025
@DavidHuber-NOAA
Fix error log parsing in compute build CI (#3301)
989948c 
This PR adds a new feature to capture and report which compute builds
failed when running CI.

Resolves #3296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA

Labels
bug Something isn't working CI/CD Issue related to CI/CD triage Issues that are triage
Projects
None yet
Milestone
No milestone
1 participant
@TerrenceMcGuinness-NOAA