Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix for cleaning DATAROOT from failed CI cases #3066

Closed
TerrenceMcGuinness-NOAA opened this issue Nov 4, 2024 · 1 comment
Closed

Bug fix for cleaning DATAROOT from failed CI cases #3066

TerrenceMcGuinness-NOAA opened this issue Nov 4, 2024 · 1 comment
Assignees
@TerrenceMcGuinness-NOAA
Labels
bug Something isn't working CI/CD Issue related to CI/CD

Comments

@TerrenceMcGuinness-NOAA
Copy link
Collaborator

TerrenceMcGuinness-NOAA commented Nov 4, 2024 •
edited
Loading

What new functionality do you need?

Currently we clear DATAROOT for each CI case on completion per its tagged hash label. This needs to be extended to also preform the action on creation to cover for the corner cases when an experiment has failed and is being re-ran that still has the same hash label.

What are the requirements for the new functionality?

Fix the above bug with updates to the pipeline

Suggest a solution (optional)

Code the solution directly in the pipeline to delete the DATA_DIR before creation of the EXPDIR
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added feature New feature or request triage Issues that are triage labels Nov 4, 2024
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA added bug Something isn't working CI/CD Issue related to CI/CD and removed feature New feature or request triage Issues that are triage labels Nov 4, 2024
@DavidHuber-NOAA DavidHuber-NOAA changed the title Bug fix for clearning DATA_DIR from failed CI cases Bug fix for cleaning DATA_DIR from failed CI cases Nov 5, 2024
@DavidHuber-NOAA
Copy link
Contributor

@TerrenceMcGuinness-NOAA Could this be moved into the setup scripts? Since this has been an issue for users as well, it might be good to have the option for them to delete DATAROOT along with COMROOT and EXPDIR. See #3071.

Closed
12 tasks
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA changed the title Bug fix for cleaning DATA_DIR from failed CI cases Bug fix for cleaning DATAROOT from failed CI cases Nov 6, 2024
Merged
21 tasks
WalterKolczynski-NOAA pushed a commit to WalterKolczynski-NOAA/global-workflow that referenced this issue Nov 22, 2024
@TerrenceMcGuinness-NOAA @WalterKolczynski-NOAA
Remove RUNDIRS before running CI cases to cover re-run events (NOAA-E…
a87bcde 
…MC#3076)

This Pr removes **pslot** dir (with hash) from local archive folder on
CI case completion and also adds `cleanup_experiment` function in the
BASH utilities to clean up after a CI case runs. This change
consolidates cleanup actions and adds functionality to clean the local
archive folders.

Key changes:

- Fixes bug for cleaning up the `RUNDIRS` directory before new
experiments are run in the case the pipeline is being ran for a second
time
- Updated `$HOMEgfs/ci/scripts/check_ci.sh` to use the new
`cleanup_experiment` function under the BASH CI system.
- Added `cleanup_experiment `function in
`$HOMEgfs/ci/scripts/utils/ci_utils.sh` to handle various cleanups
including:
  - COMROOT/EXPDIR per case
  - ARCDIR and ATADIR directories for archive
  - STMP/RUNDIRS/${PSLOT}
- Added get config var from EXPDIR utility
[get_config_var.py](https://github.com/NOAA-EMC/global-workflow/pull/2961/files#diff-b780733ae1d45917730364e09a6c510e79d4cc8cffad6d9020c7961c53b987bc)
for getting config values in BASH

Resolves NOAA-EMC#2954
Resolves NOAA-EMC#3066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA

Labels
bug Something isn't working CI/CD Issue related to CI/CD
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TerrenceMcGuinness-NOAA @DavidHuber-NOAA