Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (#419) #417

Merged
merged 14 commits into from
Nov 12, 2021

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Nov 4, 2021

Description

This PR:

Issue(s) addressed

Fixes ufs-community/ufs-weather-model#895
Fixes #418 (thanks, @HelinWei-NOAA)

Dependencies

Testing

See ufs-community/ufs-weather-model#897

@climbfuji climbfuji changed the title Register diagnostics from stochastic physics only if allocated Register diagnostics from stochastic physics only if allocated; ccpp-physics: Update convective transportable tracer handling for GFDL-MP Nov 4, 2021
@climbfuji climbfuji marked this pull request as ready for review November 4, 2021 17:33
@climbfuji climbfuji changed the title Register diagnostics from stochastic physics only if allocated; ccpp-physics: Update convective transportable tracer handling for GFDL-MP Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: Update convective transportable tracer handling for GFDL-MP Nov 4, 2021
@climbfuji climbfuji changed the title Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: Update convective transportable tracer handling for GFDL-MP Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1 Nov 8, 2021
@climbfuji climbfuji changed the title Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1 Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (#419) Nov 9, 2021
@climbfuji climbfuji requested a review from pjpegion November 10, 2021 20:01
@climbfuji
Copy link
Collaborator Author

Updated submodule pointer for ccpp-physics is correct (b8b7c31). This PR is ready to merge.

@junwang-noaa junwang-noaa merged commit 720d4a0 into NOAA-EMC:develop Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants