-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (#419) #417
Merged
junwang-noaa
merged 14 commits into
NOAA-EMC:develop
from
climbfuji:fix_stochastic_diag_output
Nov 12, 2021
Merged
Register diagnostics from stochastic physics only if allocated, fix duplicate symbols error on macOS; ccpp-physics: cleanup CCPP cmake flags part 1; contains "fix the number of 2d fields nsfcprop2d" (#419) #417
junwang-noaa
merged 14 commits into
NOAA-EMC:develop
from
climbfuji:fix_stochastic_diag_output
Nov 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.txt to avoid duplicate symbol errors
…fuji/fv3atm into fix_stochastic_diag_output
…_stochastic_diag_output
…I control changes
…_stochastic_diag_output
Updated submodule pointer for ccpp-physics is correct (b8b7c31). This PR is ready to merge. |
junwang-noaa
approved these changes
Nov 11, 2021
HelinWei-NOAA
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
GFS_diagnostics.F90
that registered several stochastic variables as diagnostic output even though th arrays are not allocated if the corresponding stochastic option is turned offccpp/CMakeLists.txt
that get added automatically by CCPPIssue(s) addressed
Fixes ufs-community/ufs-weather-model#895
Fixes #418 (thanks, @HelinWei-NOAA)
Dependencies
Testing
See ufs-community/ufs-weather-model#897