Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the P7b run to run reproducibility issue #341

Merged
merged 2 commits into from
Jul 13, 2021
Merged

fix the P7b run to run reproducibility issue #341

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
336cd73
fix the omp threading reproducibility issue
junwang-noaa Jul 13, 2021
fe083ba
fix the typo
junwang-noaa Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion io/FV3GFS_io.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1300,7 +1300,7 @@ subroutine sfc_prop_restart_read (Sfcprop, Atm_block, Model, fv_domain, warm_sta
compute_tsfc_zorl_for_colstart: if (.not. warm_start) then
if(Model%frac_grid) then ! 3-way composite
if (Model%me == Model%master ) call mpp_error(NOTE, 'gfs_driver::surface_props_input - computing composite tsfc and zorl')
!$omp parallel do default(shared) private(nb, ix)
!$omp parallel do default(shared) private(nb, ix, term1, tem)
Copy link
Collaborator

@DeniseWorthen DeniseWorthen Jul 13, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be tem, tem1. I got a compile error using "term1"

do nb = 1, Atm_block%nblks
do ix = 1, Atm_block%blksz(nb)
Sfcprop(nb)%tsfco(ix) = max(con_tice, Sfcprop(nb)%tsfco(ix)) ! this may break restart reproducibility
Expand Down