Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/doxygen no errors #611

Merged

Conversation

MatthewMasarik-NOAA
Copy link
Collaborator

Pull Request Summary

Fixes the existing doxygen errors prior to submitting doxygen marked-up code.

Description

Doxygen scans and generates some amount of documentation for code even without adding doxygen markup to it. It's possible for legal code to cause the doxygen parser to become confused and produce an error. It was suggested by @edwardhartnett to remove all errors from a code base, then going forward require all submissions to be doxygen-error free. This PR removes the remaining doxygen errors in the code base.

Please also include the following information:

  • Add any suggestions for a reviewer
    • N/A.
  • Mention any labels that should be added:
    • documentation.
  • Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply:
    • No answers are expected to change. There were edits to the source code, but only to express the same statements in a slightly different way to satisfy the doxygen parser. The meaning of both expressions is identical.

Issue(s) addressed

N/A.

Commit Message

doxygen: remove existing doxygen errors prior to markup

Check list

Testing

  • How were these changes tested?

    • The full matrix was run against current develop.
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)

    • No. The changes are for documentation purposes, not functionality.
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?

    • Yes. hera.intel.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

  • Please indicate the expected changes in the regression test output (Note the known list of non-identical tests).

    • Only entries in the list of known non-identical cases.
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (13 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (6 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)
ww3_ufs1.1/./work_d                     (0 files differ)
ww3_ufs1.2/./work_b                     (0 files differ)
ww3_ufs1.3/./work_a                     (1 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

@JessicaMeixner-NOAA
Copy link
Collaborator

Regtests were as expected and posted here.

matrixDiff.txt
matrixCompFull.txt
matrixCompSummary.txt

@JessicaMeixner-NOAA JessicaMeixner-NOAA merged commit 013f342 into NOAA-EMC:develop Feb 16, 2022
@MatthewMasarik-NOAA MatthewMasarik-NOAA deleted the doc/doxygen-no-errors branch March 7, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants