UKMO staging [develop] #237 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to ensure they comply with the limits of the nameslist.
Changes to add support to 360-day and 365-day (no leap year) calendar - see ticket #209 * Additional CALTYPE namelist parameter in MISC section * New ww3_tc1 regtest.
* Updated ww3_bound and ww3_bounc to handle model grids formulated on a rotated pole. * Manual and nml/inp files to updated clarify that ww3_bound/ww3_bounc only accept input spectra formulated on a standard pole grid.
Updates to allow a coupling time step that is different from the model time step. * Includes new regtest (in ww3_tp2.14) for non-default oasis time step. * ww3_tp2.14 regtest added to matrix.base.
aliabdolali
requested review from
ukmo-ccbunney and
ukmo-juan-castillo
and removed request for
ukmo-ccbunney
ukmo-juan-castillo
approved these changes
Aug 10, 2020
ukmo-juan-castillo
approved these changes
Aug 10, 2020
|
Thank you @ukmo-juan-castillo |
JessicaMeixner-NOAA
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
This supersedes #237 by adding fixes from @aliabdolali This should close PR237 after being merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This staging branch is simply a branch from develop that is used to stage multiple PRs in the UKMO repo to facilitate a merge to the authoritative NOAA develop branch.
This staging branch contains changes from the follow UKMO PRs:
ukmo-waves#6: boundary checks to the SMC input files for ww3_grid
ukmo-waves#8: 360 day climate calendar
ukmo-waves#9: Coupling time
ukmo-waves#10: RTD support for ww3_boun[dc]
See the individual PRs for specific regtest output.
All tests compared as OK with the following expected differences:
all tests are showing changes in mod_def and ww3_gridout* due to the addition of the calendar option ukmo-waves#8.
the ww3_tp2.14 tests are showing a difference inTOY_OUTPUT.txt (extra line saying APPLE Partitioning); this line was originally output randomly (processor dependant), but is now always output.
ww3_tp2.18/work_TIDE_MPI/ww3_prtide_current.out_diff.txt shows lots of differences - this is a known issue (see #225)
The usual differences with mww3_test_03
The complete regtest suite output on UKMETb machine is provided in the attached zip file:
matrixComp (1).zip
The complete regtest suite output on Hera
matrix_diff_ncep.zip
is provided in the attached zip file: