Addition of Regression Test (ww3_tic1.1/IC4_M10) Aligned with New Feature from PR #1293 #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaMeixner-NOAA
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
Thanks for adding the regtest @sbanihash
**********************************************************************
************************ identical cases *****************************
**********************************************************************
ww3_tic1.1/./work_IC4_M10
matrixCompFull.txt
matrixCompSummary.txt
I just ran the one new test, as you have run the others for the PR.
ukmo-ccbunney
added a commit
to ukmo-waves/WW3
that referenced
this pull request
Dec 19, 2024
…ce_refactor * upstream/develop: Addition of Regression Test (ww3_tic1.1/IC4_M10) (NOAA-EMC#1331) IC4M10: New wave damping scheme in sea ice (NOAA-EMC#1293) Fixing uninitialized issues within the implicit scheme (NOAA-EMC#1142) ww3_ufs1.x: fix typo in switch_MPI_OMPH (NOAA-EMC#1323) README.md: update with link to doxygen documentation (NOAA-EMC#1316)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR adds a regression test(ww3_tic1.1/IC4_M10) that can test the new wave attenuation scheme developled in PR#1293
Description
New test case was added to further test the wave attenuation scheme. As also mentioned by the original developer, this feature requires the use of the IS0 switch (no additional scattering term) and sea ice floe size diameter as input from ICECOEF5.
Please also include the following information:
Commit Message
regression test addition for capturing IC4_M10 (#1293 ) developed by @erinethomas.
Check list
Testing
Ran regression test individually, checked prep,run and post job log files, ww3 outputs. Re-ran test to confirm reproducibility. Full matrix runs with WW3/develop and comparision with matrix runs with this PR branch are also all normal. (Comp files are attached, new regtest added in this PR shows as not found in comparison since this test in new)
matrixDiff.txt
matrixCompSummary.txt
matrixCompFull.txt