Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule pointer for cmake #99

Merged

Conversation

climbfuji
Copy link
Contributor

Update submodule pointer for cmake following NOAA-EMC/CMakeModules#26.

@climbfuji
Copy link
Contributor Author

Can't merge, no permissions.

@fossell
Copy link
Contributor

fossell commented Feb 26, 2020

@climbfuji I'll merge this is you approve. We added branch protection to require review before merging, perhaps we need set something else to allow you to merge? You are a collaborator of EMC_post right?

@climbfuji
Copy link
Contributor Author

Not sure if only admins count as approving reviews if the CODEOWNERS functionality is not used. Or the box "require approval from CODEOWNERS" is ticked?

@fossell
Copy link
Contributor

fossell commented Feb 26, 2020

@climbfuji - Hmm, it wasn't before but I will check. I'll merge this in the meantime

@fossell
Copy link
Contributor

fossell commented Feb 26, 2020

@climbfuji - Nope you're right, I can't merge anymore either. So Wen and I talked about adding the "restrict who can push to matching branch" option and originally used that option and added me, but I didn't want to be delaying any rapid mods so went back to just "request review" first. But I didn't know about this admin limit to merge. Let me discuss with Wen how to proceed. Perhapps we need a list of maintainers who can have access to push to this branch. If that's the route we go, please let me know who should have access on your end.

@climbfuji
Copy link
Contributor Author

@fossell can you make me admin for this repo, even if just temporary? then I can take a look at the settings.

@fossell
Copy link
Contributor

fossell commented Feb 26, 2020

@climbfuji Wish I could, I'm not an admin either, they are pretty limiting on who they allow access. I requested access again from EMC, I'll keep you posted.

@mark-a-potts
Copy link
Contributor

mark-a-potts commented Feb 26, 2020 via email

@climbfuji
Copy link
Contributor Author

I just made you an admin Dom.
-M
On 2/26/20 4:01 PM, Kate Fossell wrote: @climbfuji https://github.com/climbfuji Wish I could, I'm not an admin either, they are pretty limiting on who they allow access. I requested access again from EMC, I'll keep you posted. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#99?email_source=notifications&email_token=AH4Q2USPOF6FDXAPEJYDOZ3RE3KDFA5CNFSM4K4NGOQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENB32AI#issuecomment-591641857>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH4Q2UR65MPQ4XFGKPTHF4LRE3KDFANCNFSM4K4NGOQQ.
-- Mark A. Potts, Ph.D. Sr. HPC Software Developer RedLine Performance Solutions, LLC Phone 202-744-9469 [email protected] [email protected]

Thanks, yes that does the trick. Will merge now.

@climbfuji climbfuji merged commit a1f6046 into NOAA-EMC:release/public-v8 Feb 26, 2020
guoqing-noaa pushed a commit to guoqing-noaa/UPP that referenced this pull request Apr 28, 2022
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
Changes to input.nml and diag_table template files to avoid overheati…
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
…-EMC#99)

* Fix a bug where 1-element array of additional output grids is erroneously converted to a string

* Use different interpolation methods for different grid spacings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants