-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodule pointer for cmake #99
Update submodule pointer for cmake #99
Conversation
Can't merge, no permissions. |
@climbfuji I'll merge this is you approve. We added branch protection to require review before merging, perhaps we need set something else to allow you to merge? You are a collaborator of EMC_post right? |
Not sure if only admins count as approving reviews if the CODEOWNERS functionality is not used. Or the box "require approval from CODEOWNERS" is ticked? |
@climbfuji - Hmm, it wasn't before but I will check. I'll merge this in the meantime |
@climbfuji - Nope you're right, I can't merge anymore either. So Wen and I talked about adding the "restrict who can push to matching branch" option and originally used that option and added me, but I didn't want to be delaying any rapid mods so went back to just "request review" first. But I didn't know about this admin limit to merge. Let me discuss with Wen how to proceed. Perhapps we need a list of maintainers who can have access to push to this branch. If that's the route we go, please let me know who should have access on your end. |
@fossell can you make me admin for this repo, even if just temporary? then I can take a look at the settings. |
@climbfuji Wish I could, I'm not an admin either, they are pretty limiting on who they allow access. I requested access again from EMC, I'll keep you posted. |
I just made you an admin Dom.
-M
On 2/26/20 4:01 PM, Kate Fossell wrote:
@climbfuji <https://github.com/climbfuji> Wish I could, I'm not an
admin either, they are pretty limiting on who they allow access. I
requested access again from EMC, I'll keep you posted.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#99>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4Q2UR65MPQ4XFGKPTHF4LRE3KDFANCNFSM4K4NGOQQ>.
--
Mark A. Potts, Ph.D.
Sr. HPC Software Developer
RedLine Performance Solutions, LLC
Phone 202-744-9469
[email protected]
[email protected]
|
Thanks, yes that does the trick. Will merge now. |
Changes to input.nml and diag_table template files to avoid overheati…
…-EMC#99) * Fix a bug where 1-element array of additional output grids is erroneously converted to a string * Use different interpolation methods for different grid spacings
Update submodule pointer for cmake following NOAA-EMC/CMakeModules#26.