Fix post crash on macOS #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
requested review from
WenMeng-NOAA,
DusanJovic-NOAA,
kgerheiser and
mark-a-potts
DusanJovic-NOAA
approved these changes
Feb 18, 2020
mark-a-potts
approved these changes
Feb 19, 2020
guoqing-noaa
pushed a commit
to guoqing-noaa/UPP
that referenced
this pull request
Apr 28, 2022
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
Community develop
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
…OAA-EMC#81) * Expand capability for producing additional output grids with wgrib2 * Update config_defaults.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the declaration of the cgrib array to prevent a post crash on macOS ("illegal instruction"). This is not a bug in the code, but on macOS I believe. The same bug was previously fixed in gfsphysics'
sfcsub.F. The new/alternative declaration is valid Fortran.Also correcting minor typos/replace tab with spaces.
I have tested this thus far on macOS and Redhat Linux.