Initialize n_clouds=0 and print msg, when not defined for certain mp_… #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoqing-noaa
pushed a commit
to guoqing-noaa/UPP
that referenced
this pull request
Apr 28, 2022
## DESCRIPTION OF CHANGES: Currently master is broken and will not build and/or run on any platform due to incompatible hashes and outdated changes. Several fixes are needed to get master back in working order, most of which will be included in this PR. The direct changes made in ufs-srweather-app for this PR are: - Partially cherry-picking release-branch changes to update build system and documentation - Updating static hashes to the latest versions of `develop` branches for ufs-weather-model, EMC_post, UFS_UTILS, and regional_workflow Some changes that were needed prior to this PR being merged are: - [x] EMC_post needs to be updated to include an updated executable name and flat config files - NOAA-EMC#237 - [x] regional_workflow needs to be updated for the new ufs-weather-model executable name - https://github.com/NOAA-EMC/regional_workflow/pull/374 - [x] regional_workflow also needs to be updated for changed namelist options in the latest ufs-weather-model develop branch - https://github.com/NOAA-EMC/regional_workflow/pull/377 - [x] regional_workflow also needs to be updated with the commit in https://github.com/NOAA-EMC/regional_workflow/pull/343 in order for the workflow and automated tests to work on Cheyenne - https://github.com/NOAA-EMC/regional_workflow/pull/378 These PRs have been merged and this PR updated with the latest hashes. ## TESTS CONDUCTED: Compiles and workflow is successfully generated on Cheyenne, Hera, and Jet; ran many tests that all passed; reference PR on Github for full list. ## ISSUE: Resolves NOAA-EMC#57
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…physics