Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufs_release_1.0: cleanup work 2020/01/06 #42

Merged

Conversation

climbfuji
Copy link
Contributor

@climbfuji climbfuji commented Jan 6, 2020

  • update submodule pointer for cmake, add branch information
  • update include/lib flags for nemsio, sigio, sfcio in sorc/ncep_post.fd/CMakeLists.txt
  • add REQUIRED attribute to find_package calls

@climbfuji
Copy link
Contributor Author

@DusanJovic-NOAA do you know if LAPACK is a required dependency for NCEPLIBS-post? If I comment out find_package(LAPACK) it still compiles fine, but I don't know if this is because the system finds the lapack libraries automatically in the system include/library paths. Similar question for NCEPLIBS-grib_util. Thanks!

@DusanJovic-NOAA
Copy link
Contributor

@DusanJovic-NOAA do you know if LAPACK is a required dependency for NCEPLIBS-post? If I comment out find_package(LAPACK) it still compiles fine, but I don't know if this is because the system finds the lapack libraries automatically in the system include/library paths. Similar question for NCEPLIBS-grib_util. Thanks!

I think it does not require LAPACK. I also commented out find_package(LAPACK) and successfully built the EMC_post.

@climbfuji
Copy link
Contributor Author

Thanks, will comment them out in the PRs.

@climbfuji climbfuji marked this pull request as ready for review January 7, 2020 21:01
@climbfuji
Copy link
Contributor Author

climbfuji commented Jan 9, 2020

@Hang-Lei-NOAA actually can you merge this PR, please? I do not have write access to EMC_post. Thanks! It is ready to go.

@fossell
Copy link
Contributor

fossell commented Jan 9, 2020

@climbfuji - I'll merge this for you.

@fossell fossell merged commit 9bd8aed into NOAA-EMC:ufs_release_v1.0 Jan 9, 2020
@Hang-Lei-NOAA
Copy link

Hang-Lei-NOAA commented Jan 9, 2020 via email

@Hang-Lei-NOAA
Copy link

Hang-Lei-NOAA commented Jan 9, 2020 via email

@climbfuji
Copy link
Contributor Author

Thanks to both of you, Kate and Hang!

@DusanJovic-NOAA
Copy link
Contributor

DusanJovic-NOAA commented Jan 9, 2020

${GFSIO_INC} should be ${GFSIO_INC4} in sorc/ncep_post.fd/CMakeLists.txt, here:

https://github.com/NOAA-EMC/EMC_post/blob/9bd8aed6418550842dfae1e0d9fd3a8aa915908f/sorc/ncep_post.fd/CMakeLists.txt#L191

For example, these are environment variables set by gfsio module on wcoss_dell_p3:

$ module show gfsio/1.1.0
--------------------------------------------------------------------------------------------------------------------------------------------
   /gpfs/dell1/nco/ops/nwprod/modulefiles/compiler_prod/ips/18.0.1/gfsio/1.1.0:
--------------------------------------------------------------------------------------------------------------------------------------------
conflict("gfsio")
setenv("COMP","ips")
setenv("GFSIO_SRC","/gpfs/dell1/nco/ops/nwprod/lib/gfsio/v1.1.0/src")
setenv("GFSIO_INC4","/gpfs/dell1/nco/ops/nwprod/lib/gfsio/v1.1.0/ips/18.0.1/include/gfsio_v1.1.0_4")
setenv("GFSIO_LIB4","/gpfs/dell1/nco/ops/nwprod/lib/gfsio/v1.1.0/ips/18.0.1/libgfsio_v1.1.0_4.a")
setenv("GFSIO_VER","v1.1.0")
help([[Set environment variables for gfsio library, including GFSIO_SRC, GFSIO_INC4, and GFSIO_LIB4]])

@climbfuji
Copy link
Contributor Author

${GFSIO_INC} should be ${GFSIO_INC4} in sorc/ncep_post.fd/CMakeLists.txt, here:

https://github.com/NOAA-EMC/EMC_post/blob/9bd8aed6418550842dfae1e0d9fd3a8aa915908f/sorc/ncep_post.fd/CMakeLists.txt#L191

Thanks, will fix it in a minute.

@climbfuji
Copy link
Contributor Author

${GFSIO_INC} should be ${GFSIO_INC4} in sorc/ncep_post.fd/CMakeLists.txt, here:
https://github.com/NOAA-EMC/EMC_post/blob/9bd8aed6418550842dfae1e0d9fd3a8aa915908f/sorc/ncep_post.fd/CMakeLists.txt#L191

Thanks, will fix it in a minute.

See here: #43 - will merge right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants