-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge DTC_post into develop branch #131
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs with GNU for community
… These have not been used operationally for a while. This commit is merely to sync the community and emc code bases
…in/, and external/ directories from a successful WRF build, this version compiles and runs successfully
Now contains a new directory "wrf_io/" with its own makefile for building the relevant WRF code. Now you no longer have to pre-build WRF, only run the configure script to create a configure.wrf file. To build this version: - Copy in the external/, frame/, inc/, main/, Registry/, and tools/ directories from the RAW UNBUILT WRF source code into the new wrf_io/ directory - Copy in a configure.wrf file created with that same WRF source code Should be able to pare down the above list soon, many of them are only needed for one or two files (or perhaps ultimately none) This version was tested with the WRF V4.0 Friendly Release #3 (git hash e96ef955), but it should work for a wide range of WRF code
included in wrf_io makefile
…ired! - Added "wrf_makerules" file to be included in a couple makefiles - Contains configure.wrf preamble and postamble, but no platform-specific stuff! - Still need to copy over WRF directories, *and* properly check out the versioned files - Modified frame Makefile to remove an unnecessary compilation - Hopefully a lot more of this in the future!
… directory in from WRF.
to be copied in to wrf_io/ directory - Versioned the necessary files in frame/ from the WRF build. - Moved depend.common from main/ to frame/, and versioned it - Build libwrflib.a in the wrf_io/ directory instead of wrf_io/main/
…ut hard-coding is bad, mmkay
…rial compile. Tests now work for options 7 and 8 (gfortran serial and parallel) - Link in already existing UPP stub mpi library files for WRF serial build - Use already existing "sw_dmparallelflag" switch from configure to pass -DSTUBMPI flag for serial builds - Remove clog.o file which is only needed for log file buffering, which is rarely used in WRF and certainly not supported for UPP. - While removing log file buffering, also remove a lot of other unsupported CPP ifdefs
Merge HWRF mods into DTC_post
…onflict with Himawari number set
Additional mods for Himawari satellite output
WenMeng-NOAA
reviewed
Jun 4, 2020
WenMeng-NOAA
reviewed
Jun 5, 2020
WenMeng-NOAA
reviewed
Jun 6, 2020
WenMeng-NOAA
reviewed
Jun 8, 2020
WenMeng-NOAA
reviewed
Jun 8, 2020
The regression tests are conducted on Dell, Cray and Hera. No changed results are found. The PR is ready to be merged into develop. @fossell Will you open an issue on github for the PR so we can track the changes. Thanks! |
WenMeng-NOAA
approved these changes
Jun 9, 2020
@WenMeng-NOAA Issue #133 has been created. |
guoqing-noaa
added a commit
to guoqing-noaa/UPP
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a large merge that incorporates DTC_post contents into develop branch. This includes:
This branch has been merged with develop and is up-to-date. EMC reg tests were run on Hera successfully with bit-wise results for all tests. Community platform testing was also successful.
One important note: This merge includes new code for outputting Himawari satellite fields (from HWRF group). This requires adding the Himawari coefficient files to (ahi_himawari8.SpcCoeff.bin & ahi_himawari8.TauCoeff.bin) to the fix directory in the EMC regression testing framework on the system (Hera for tests to be successful for rap/hrrr. We have already added "ahi_himawari" to the link_crtm_fix.sh script for GFS special file.