Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correct installation directory for Fortran module files. #130

Merged
merged 1 commit into from
May 26, 2020
Merged

correct installation directory for Fortran module files. #130

merged 1 commit into from
May 26, 2020

Conversation

aerorahul
Copy link
Contributor

This PR fixes the installation path of compiled Fortran module files.

Previously their destination was:
${CMAKE_INSTALL_PREFIX}/include/include

This has now been corrected to:
${CMAKE_INSTALL_PREFIX}/include

closes #129

@aerorahul aerorahul added the bug Something isn't working label May 21, 2020
fossell
fossell approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@fossell fossell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change only impacts cmake builds, no impact to unipost functions. I can merge once approval given by another release team member.

@fossell fossell merged commit 87f9840 into NOAA-EMC:release/public-v1 May 26, 2020
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request May 30, 2020
Closed
@aerorahul aerorahul deleted the bugfix/installdir branch June 29, 2020 00:15
guoqing-noaa pushed a commit to guoqing-noaa/UPP that referenced this pull request Apr 28, 2022
@hu5970
Update hash for base C with non var cloud analysis on subdomains. (NO…
b293b7a 
…AA-EMC#130)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fossell fossell fossell approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@climbfuji climbfuji Awaiting requested review from climbfuji

@kgerheiser kgerheiser Awaiting requested review from kgerheiser

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aerorahul @fossell @DusanJovic-NOAA @WenMeng-NOAA