Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a line to fixed the bug of scattering calculation #120

Closed
zhanglikate opened this issue Apr 23, 2020 · 5 comments
Closed

Adding a line to fixed the bug of scattering calculation #120

zhanglikate opened this issue Apr 23, 2020 · 5 comments

Comments

@zhanglikate
Copy link
Contributor

Change line " IF (IDECID == 17 ) THEN" as
"IF (IDECID == 17 .or. IDECID == 20 .or. IDECID == 21) THEN"
@WenMeng-NOAA
Copy link
Collaborator

WenMeng-NOAA commented Apr 23, 2020 •
edited
Loading

Kate's change was submitted at the PR #121 at
#121

@zhanglikate
Copy link
Contributor Author

zhanglikate commented Apr 23, 2020 via email

@WenMeng-NOAA
Copy link
Collaborator

WenMeng-NOAA commented Apr 23, 2020 •
edited
Loading

Kate,

You are right. The new change was added in the PR #122.

@WenMeng-NOAA
Copy link
Collaborator

WenMeng-NOAA commented Apr 23, 2020 •
edited
Loading

The branch gefs_v12_release was committed at @0baf6bf with the bug fix of scattering calculation.

@WenMeng-NOAA
Copy link
Collaborator

On 11/06/2020, this fix was synced in branch develop with PR #217 at 43ba912.

guoqing-noaa pushed a commit to guoqing-noaa/UPP that referenced this issue Apr 28, 2022
Add support for git sparse checkout
34fbf55 
Added a new, optional external property, sparse. sparse points to a file (relative to external repository local directory) with git sparse checkout patterns (e.g., directory names to include).
If the sparse keyword is included, enable sparse checkout for that repository and use git read-tree to perform the sparse checkout.

Added a new test for sparse checkout. The test is a repo with two externals which are both tag2 of the simple_ext repo with one of them configured for a sparse checkout. The test makes sure that both externals have the correct files.

Updated the documentation for the externals configuration file.

User interface changes?: Yes
New sparse keyword is optional with a blank default value which preserves current functionality.

Fixes: NOAA-EMC#120

Testing:
test removed: None
unit tests: All passed
system tests: All passed, including new test for sparse feature
manual testing: Several manual tests of NASA test cases.
guoqing-noaa pushed a commit to guoqing-noaa/UPP that referenced this issue Apr 28, 2022
@hu5970
Update hash for BaseB (NOAA-EMC#120)
dfa53af
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this issue Dec 14, 2022
@JeffBeck-NOAA
Merge pull request NOAA-EMC#120 from JeffBeck-NOAA/community_develop
7aef70d 
Change path to fix_am on Hera for build_regional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WenMeng-NOAA @zhanglikate