Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeb sar #7

Merged
merged 5 commits into from
Mar 11, 2020
Merged

Skeb sar #7

merged 5 commits into from
Mar 11, 2020

Conversation

pjpegion
Copy link

@pjpegion pjpegion commented Nov 8, 2019

This pull request is to address an issue with NaN values in the halo region of the dissipation estimate (used for SKEB) in the FV3-SAR application. The does not affect the global model since the halo is filled with values from the other cube faces.

@junwang-noaa
Copy link
Collaborator

Phil,

Would you please suggest 2 code reviewers for this pull request? Please let me know if you can't add them to the pull request. Thanks.

@pjpegion
Copy link
Author

Hi Jun,
I will suggest Jeff Beck, Rusty benson, and Dom. And I don't see how I can add them as reviers.
-Phil

@pjpegion
Merge pull request #2 from NOAA-EMC/dev/emc
feaf652 
update noaa-psd fork with EMC develop branch
@pjpegion
Copy link
Author

pjpegion commented Mar 2, 2020

@junwang-noaa @climbfuji I just updated by skeb_sar branch with dev/emc. This addition only changes the results for the FV3-SAR, global model is not affected.

@junwang-noaa junwang-noaa requested a review from bensonr March 2, 2020 21:22
@bensonr
Copy link
Collaborator

bensonr commented Mar 2, 2020

@pjpegion just to be clear, the desired behavior for SAR is to smooth the diss_est variable with the values of zero in the halo region? Other choices are to a) set the halo region to the value of the edge cells or b) mirror interior points into the halo region.

@pjpegion
Copy link
Author

pjpegion commented Mar 2, 2020

@bensonr Yes this is the intention. There is an open science question about which was is the best, but I feel that starting with zero's in the halo region is a good starting point. I rather have SKEB to too little than too much.

bensonr
bensonr approved these changes Mar 3, 2020
View reviewed changes
Copy link
Collaborator

@bensonr bensonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

climbfuji
climbfuji approved these changes Mar 4, 2020
View reviewed changes
Copy link

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@junwang-noaa junwang-noaa self-requested a review March 11, 2020 18:32
@junwang-noaa junwang-noaa merged commit 371a29a into NOAA-EMC:dev/emc Mar 11, 2020
@climbfuji climbfuji mentioned this pull request Mar 13, 2020
Merged
junwang-noaa pushed a commit that referenced this pull request Apr 17, 2020
@climbfuji
Merge NCAR:dtc/develop into NOAA-EMC:dev/emc
34b4503 
- bugfix for GNU compiler
- reduce noise in stdout

Squashed commit of the following:

commit 86c127f
Merge: ce66d6a f9bbb4f
Author: Dom Heinzeller <[email protected]>
Date:   Fri Apr 10 11:32:21 2020 -0600

    Merge pull request #11 from climbfuji/update_dtc_develop_from_dev_emc_20200409

    Update dtc/develop from dev/emc 2020/04/09

commit f9bbb4f
Author: Dom Heinzeller <[email protected]>
Date:   Thu Apr 9 20:14:24 2020 -0600

    Bugfix for GNU compiler in model/fv_regional_bc.F90, reduce verbosity in driver/fvGFS/atmosphere.F90

commit ecca997
Merge: ce66d6a 80ce8ce
Author: Dom Heinzeller <[email protected]>
Date:   Thu Apr 9 09:38:48 2020 -0600

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit ce66d6a
Merge: 4279bf7 9bacf55
Author: Dom Heinzeller <[email protected]>
Date:   Fri Mar 13 13:00:41 2020 -0600

    Merge pull request #10 from climbfuji/update_from_dev_emc_20200312_and_other_changes

    Update from dev/emc 2020/03/12

commit 9bacf55
Merge: 4279bf7 371a29a
Author: Dom Heinzeller <[email protected]>
Date:   Thu Mar 12 10:33:44 2020 -0600

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit 4279bf7
Merge: 846f5a5 4858d33
Author: Dom Heinzeller <[email protected]>
Date:   Mon Mar 9 12:41:51 2020 -0600

    Merge pull request #9 from climbfuji/update_dtc_develop_from_emc

    Update dtc/develop from dev/emc 2020/03/04

commit 4858d33
Merge: 846f5a5 db3acfb
Author: Dom Heinzeller <[email protected]>
Date:   Fri Feb 28 08:46:55 2020 -0700

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit 846f5a5
Merge: 3a4dfd8 9a290ee
Author: Dom Heinzeller <[email protected]>
Date:   Mon Feb 3 07:43:08 2020 -0700

    Merge pull request #7 from climbfuji/update_dtc_develop_from_dev-emc

    dtc/develop: update from dev/emc 2020/01/27

commit 9a290ee
Merge: 3a4dfd8 a56907a
Author: Dom Heinzeller <[email protected]>
Date:   Mon Jan 27 09:28:57 2020 -0700

    Merge branch 'dev/emc' of https://github.com/noaa-emc/GFDL_atmos_cubed_sphere into HEAD

commit 3a4dfd8
Merge: 0c9ab9e 68576a6
Author: Dom Heinzeller <[email protected]>
Date:   Tue Dec 3 15:19:24 2019 -0700

    Merge pull request #6 from climbfuji/dtc_develop_udpate_from_emc_20191127

    dtc/develop: update from EMC 2019/11/27

commit 68576a6
Merge: 0c9ab9e 452333a
Author: Dom Heinzeller <[email protected]>
Date:   Wed Nov 27 14:13:08 2019 -0700

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit 0c9ab9e
Merge: 9871607 b280b37
Author: Dom Heinzeller <[email protected]>
Date:   Fri Nov 22 16:17:57 2019 -0700

    Merge pull request #5 from mzhangw/HAFS_fer_hires

    minimal changes to make nwat =4 compatible with Ferrier-Aligo MP scheme

commit b280b37
Author: Man.Zhang <[email protected]>
Date:   Tue Nov 19 14:53:57 2019 -0700

    bug fix

commit 98c58ad
Author: Man.Zhang <[email protected]>
Date:   Tue Nov 19 14:35:10 2019 -0700

    bug fix

commit 8805acd
Author: Man.Zhang <[email protected]>
Date:   Tue Nov 19 14:16:22 2019 -0700

    From Chunxi: The file fv_mapz.F90 also needs to be modified (K_warm)

commit f8a257a
Author: Man.Zhang <[email protected]>
Date:   Thu Nov 14 19:12:39 2019 -0700

    use upper-case CCPP

commit 77f4fba
Author: Man.Zhang <[email protected]>
Date:   Thu Nov 14 13:40:59 2019 -0700

     implement FA scheme water loading option if nwat =4

commit 9871607
Merge: ed75004 786447c
Author: Dom Heinzeller <[email protected]>
Date:   Tue Nov 5 06:59:34 2019 +0900

    Merge branch 'dev/emc' of https://github.com/NOAA-EMC/GFDL_atmos_cubed_sphere into HEAD

commit ed75004
Merge: 1d6035a f627bfb
Author: Dom Heinzeller <[email protected]>
Date:   Sat Oct 12 08:45:14 2019 +0900

    Merge pull request #4 from climbfuji/update_gmtb_develop_with_vlab_master_20191006

    Update NCAR gmtb/develop with NOAA-EMC dev/emc 2019/10/06

commit f627bfb
Author: Dom Heinzeller <[email protected]>
Date:   Mon Oct 7 12:12:24 2019 +0900

    Add missing change in fv_cmp.F90 - now identical with EMC code

commit e868186
Author: Dusan Jovic <[email protected]>
Date:   Tue Sep 24 01:57:11 2019 +0000

    change delz from positive value to the original value in the model

commit 672eb0e
Author: fanglin.yang <[email protected]>
Date:   Thu Sep 5 19:24:09 2019 +0000

        VLab Issue #68141

        modified:   docs/FV3_citations.bib
        modified:   model/fv_cmp.F90

        1) Add an option (namelist parameter: intqs) to use temperature instead of the liquid frozen
        temperature to calculate saturation mixing ratio in deriving GFDLMP PDF cloud cover.
        2) Add a literature reference.

commit 1d6035a
Merge: 94ab0e1 fec8205
Author: Dom Heinzeller <[email protected]>
Date:   Mon Sep 23 09:32:55 2019 -0600

    Merge pull request #2 from climbfuji/remove_transition_mode

    Remove TRANSITION mode

commit fec8205
Author: climbfuji <[email protected]>
Date:   Fri Sep 20 08:52:01 2019 -0600

    Remove TRANSITION mode

commit 94ab0e1
Author: Jun.Wang <[email protected]>
Date:   Mon Aug 26 21:03:55 2019 +0000

    add option to output omega

commit b700cae
Author: climbfuji <[email protected]>
Date:   Fri Aug 30 11:58:00 2019 -0600

    model/fv_dynamics.F90: replicating previous change to gmtb/develop branch of FV3, always allocate dtdt_m for IPD version

commit 3df1171
Author: Laurie Carson <[email protected]>
Date:   Fri Aug 16 10:46:56 2019 -0600

    Add codeowners for NCAR fork
XiaqiongZhou-NOAA pushed a commit to XiaqiongZhou-NOAA/GFDL_atmos_cubed_sphere that referenced this pull request Sep 22, 2022
@JiliDong-NOAA
Merge pull request NOAA-EMC#7 from NOAA-GFDL/dev/emc
32f4886 
Moving Nest Functionality  (NOAA-GFDL#179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bensonr bensonr bensonr approved these changes

@climbfuji climbfuji climbfuji approved these changes

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@JeffBeck-NOAA JeffBeck-NOAA JeffBeck-NOAA approved these changes

@DusanJovic-NOAA DusanJovic-NOAA Awaiting requested review from DusanJovic-NOAA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pjpegion @junwang-noaa @bensonr @climbfuji @JeffBeck-NOAA