Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add driver script to convert GSI bias coefficient files for UFO #36

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

CoryMartin-NOAA
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA commented Mar 31, 2022

Addresses part of #7

This adds a new ush script, run_satbias_conv.py that will loop through specified cycles and convert GSI bias files (eg. gdas.t00z.abias and gdas.t00z.abias_pc) to files readable by UFO.

Usage:
./run_satbias_conv.py --config input.yaml

This input YAML file should contain the following:

start time: 2021-12-20T18:00:00Z
end time: 2021-12-21T18:00:00Z
assim_freq: 6
dump: gdas
gsi_bc_root: /path/to/gsi/rotdirs
ufo_bc_root: /path/to/output/toplevel
work_root: /path/to/toplevel/work
satbias2ioda: /path/to/build/bin/satbias2ioda.x

All three directories should/will have the structure within them:
{dump}.YYYYMMDD/HH/atmos

Still to come: the associated unit test to convert a sample GSI file, and the R2D2 test to place the converted files in R2D2

Copy link
Contributor

@guillaumevernieres guillaumevernieres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know about the science, but the code look 👍

@CoryMartin-NOAA CoryMartin-NOAA added hera-RT Queue for automated testing on Hera orion-RT Queue for automated testing on Orion labels Apr 1, 2022
@emcbot emcbot added orion-RT-Running Automated testing running on Orion hera-RT-Running Automated testing running on Hera and removed orion-RT Queue for automated testing on Orion hera-RT Queue for automated testing on Hera labels Apr 1, 2022
@emcbot
Copy link

emcbot commented Apr 1, 2022

Automated Pull Request Testing Results:
Machine: orion

Start: Fri Apr  1 15:15:14 CDT 2022 on Orion-login-1.HPC.MsState.Edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr  1 15:58:40 CDT 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Apr  1 15:59:23 CDT 2022
Tests: 100% tests passed, 0 tests failed out of 7

@emcbot emcbot added orion-RT-Passed Automated testing successful on Orion and removed orion-RT-Running Automated testing running on Orion labels Apr 1, 2022
@emcbot
Copy link

emcbot commented Apr 1, 2022

Automated Pull Request Testing Results:
Machine: hera

Start: Fri Apr  1 20:15:16 UTC 2022 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Fri Apr  1 21:07:20 UTC 2022
---------------------------------------------------
Tests:                                 *SUCCESS*
Tests: Completed at Fri Apr  1 21:07:34 UTC 2022
Tests: 100% tests passed, 0 tests failed out of 7

@emcbot emcbot added hera-RT-Passed Automated testing successful on Hera and removed hera-RT-Running Automated testing running on Hera labels Apr 1, 2022
@CoryMartin-NOAA CoryMartin-NOAA merged commit 99893f1 into develop Apr 1, 2022
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/satbias branch April 1, 2022 21:08
DavidNew-NOAA added a commit that referenced this pull request Nov 6, 2024
This PR is a companion to Global Workflow PR
[#2992](NOAA-EMC/global-workflow#2992) and
JCB-GDAS PR [#36](NOAA-EMC/jcb-gdas#36).

It makes a few necessary changes to the marine JCB base YAML required to
have JCB working in the B-matrix task in the Global Workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hera-RT-Passed Automated testing successful on Hera orion-RT-Passed Automated testing successful on Orion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants