-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gauss grid #5
Feature/gauss grid #5
Conversation
…for Gauss grid coords.
Runs, results appear reasonable.
@CoryMartin-NOAA Good reviewers would be George and Tseganeh. |
src/regridStates/gauIncr2native.nml
Outdated
@@ -0,0 +1,31 @@ | |||
&config | |||
n_vars=4, ! number of vars in list below | |||
variable_list(1)="soilt1_inc ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the space in "soilt1_inc"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do need it. Here's the gsi output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think he means the trailing spaces, not the underscore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes more sense! I believe we do need the fixed length for specifying a char array in a namelist, but will double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked! I changed it.
src/regridStates/gauIncr2native.nml
Outdated
n_vars=4, ! number of vars in list below | ||
variable_list(1)="soilt1_inc ", | ||
variable_list(2)="soilt2_inc ", | ||
variable_list(3)="slc1_inc ", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Var list in one line might be better (personal preference to save space)
variable_list="soilt1_inc","slc1_inc","",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed - see above.
src/regridStates/gauIncr2native.nml
Outdated
jres=48, | ||
fname="inc2ens.sfc_data", | ||
dir="./output/", | ||
fname_mask="20211221.090000.sfc_data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this template for mask? as in mask will be written in this file format? I am guessing it is not an actual output file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the file that is read in to get the mask. I changed the code to use a fix file instead of a restart though - so I need to change the entry here too. I'll also add a block of comments explaining each variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this file, and added comment block at the end of the example namelist.
src/regridStates/regridStates.F90
Outdated
if (ierr /= 0) call error_handler("READING input NAMELIST.", ierr) | ||
case ("output") | ||
read(unt, nml=output, iostat=ierr) | ||
if (ierr /= 0) call error_handler("READING input NAMELIST.", ierr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
src/regridStates/README
Outdated
* Only mask option right now is "soil" (no water, no land-ice). Could add others easily. | ||
* Does not guarantee all output grid cells with have mapped values, by design. | ||
* Current masking options are all soil (land, no glaciers) and snow-free soil (input increment only) | ||
* Does not guarantee all output grid cells with have mapped values, by design. CANNOT BY USED FOR RESTARTS (could be changed though). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added minor comments, but my test runs successfully as expected (apart from the namelist needing to be fully specified).
Thanks @tsga I fixed it all. |
I added an example to call the regridding here: |
i) write out the ensemble mean reanalysis, and apply it to the deterministic member. ii) replace UFS_UTILS regridding of Gaussian soil analysis to model grid with an external ESMF-based program (with appropriate land masking) Requires: sorc/gsi_enkf.fd develop after Tue Nov 12. Latest works. sorc/gdas.cd/sorc/da-utils PR: NOAA-EMC/DA-utils#5 sorc/ufs_utils.fd from PR: ufs-community/UFS_UTILS#1010
@@ -0,0 +1,45 @@ | |||
&config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noting here to move this out of src/ "eventually"
Expanded DA-utils ESMF regridding routine to also be able to regrid GSI-output increment files onto the fv3 grid: