Initialize variable so as not to keep appending. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
approved these changes
Jun 30, 2023
aerorahul
approved these changes
Jun 30, 2023
climbfuji
added a commit
that referenced
this pull request
Aug 19, 2023
This reverts commit 3bd7769.
aerorahul
pushed a commit
that referenced
this pull request
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for https://github.com/JCSDA-internal/jedi-cmake/issues/31.
Running the FindNetCDF.cmake script sets, among other thing, the NETCDF_LIBRARIES variable. It appears that repeated incremental rebuilds that include re-runs of cmake result in the contents of this variable being appended and hence constantly expanding. It would be nice if the variable wasn't appended in this way, although it doesn't cause failures.
This seems to address the issue by initialising NETCDF_LIBRARIES to an empty string before use in FindNetCDF.