Add find-package modules for GPTL, PnetCDF, udunits (unify JCSDA and EMC cmakemodules) #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal is to unify the JCSDA and EMC CMakeModules, and for this I need to add a few find-package modules that exist in https://github.com/jcsda/jedi-cmake to this repository:
Almost all of the existing files are identical between the two repos. There are tiny differences between the
FindNetCDF.cmake
files, but they are just additional comments and don't matter.There are, however, large differences between the
FindPIO.cmake
files. My strategy is to test first if the version in this repository (CMakeModules) work just fine, and if so not care about the differences. If it doesn't, come back and revisit theFindPIO.cmake
differences in a follow-up PR.Question
Do the copyright statements at the top of the new files matter? I assume not, since the existing
FindNetCDF.cmake
file has an ECMWF copyright statement at the top.Testing
This PR needs to be tested with jedi-cmake (which will be using this repo as a submodule). Requires installing a test version of jedi-cmake using spack-stack and then running our JEDI tests (with MPAS, FV3, ...).
Issues
First step (maybe the only step required) towards #65