Lets use the installed .setting file to gather version information for PIO. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgerheiser
approved these changes
Jul 26, 2022
|
I verified this worked by searching for PIO and the output is |
|
There is a pio_meta.h file, just like netcdf_meta.h... |
|
@edwardhartnett would using Either way CMake will search for a file and grep its contents. |
|
I guess it doesn't matter... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindPIO.cmake is missing a PIO_VERSION var (even states its provided, but it's not). This PR uses the install .settings file to gather the version information and passes it off to CMake.