Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AQM Needs to build in UFS debug mode #10

Closed
BrianCurtis-NOAA opened this issue Sep 12, 2022 · 3 comments
Closed

AQM Needs to build in UFS debug mode #10

BrianCurtis-NOAA opened this issue Sep 12, 2022 · 3 comments

Comments

@BrianCurtis-NOAA
Copy link
Collaborator

Build UFSWM using: CMAKE_FLAGS="-DAPP=ATMAQ -DCCPP_SUITES=FV3_GFS_v15p2 -DDEBUG=ON" ./build.sh

Get warnings resolved where build fails for AQM repo files.
@BrianCurtis-NOAA
Copy link
Collaborator Author

Files that need work right now:
src/model/CMAQ/CCTM/src/aero/aero6/isrpia.inc
and
src/model/CMAQ/CCTM/src/aero/aero6/isofwd.f

Lots of this: warning #6717: This name has not been given an explicit type

@BrianCurtis-NOAA
Copy link
Collaborator Author

More information:

With a large number of warnings resulting from the .inc file not having explicit types for its COMMON variables, the compile in debug mode fails.

The proper way to handle common blocks today is through modules. rewriting irspia.inc as a module file will take a bit of time.

The following files have include statements for irspia.inc that will need to be updated if we re-write with modules:

grep -ril "isrpia.inc" AQM
AQM/src/model/Makefile.am
AQM/src/model/Makefile.in
AQM/src/model/src/isofwd.f (and: AQM/src/model/CMAQ/CCTM/src/aero/aero6/isofwd.f)
AQM/src/model/CMAQ/CCTM/src/aero/aero6/aero_subs.F
AQM/src/model/CMAQ/CCTM/src/aero/aero6/isorev.f
AQM/src/model/CMAQ/CCTM/src/aero/aero6/isocom.f

rmontuoro added a commit to rmontuoro/AQM that referenced this issue Oct 2, 2022
@rmontuoro
Add EPA recommended debug flags for Intel compiler.
a477825 
Resolves issue NOAA-EMC#10.
@rmontuoro rmontuoro mentioned this issue Oct 2, 2022
Merged
@BrianCurtis-NOAA BrianCurtis-NOAA mentioned this issue Oct 3, 2022
Merged
16 tasks
BrianCurtis-NOAA pushed a commit that referenced this issue Oct 6, 2022
@rmontuoro
Update CMake build system (#15)
23a5994 
* Properly include custom target dependency. This fixes issue #14.

* Add EPA recommended debug flags for Intel compiler.

* Resolves issue #10.
@BrianCurtis-NOAA
Copy link
Collaborator Author

PR which addresses this issue has been merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BrianCurtis-NOAA